Skip to content

Commit 1fe8676

Browse files
antonmedvSimFG
authored andcommitted
Remove additional run API (RunWithConfig) from VM
This API was introduced in previous PR, but we do not want to expose it.
1 parent 6d56bfe commit 1fe8676

File tree

2 files changed

+2
-42
lines changed

2 files changed

+2
-42
lines changed

vm/vm.go

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -25,19 +25,6 @@ func Run(program *Program, env any) (any, error) {
2525
return vm.Run(program, env)
2626
}
2727

28-
func RunWithConfig(program *Program, env any, config *conf.Config) (any, error) {
29-
if program == nil {
30-
return nil, fmt.Errorf("program is nil")
31-
}
32-
if config == nil {
33-
return nil, fmt.Errorf("config is nil")
34-
}
35-
vm := VM{
36-
MemoryBudget: config.MemoryBudget,
37-
}
38-
return vm.Run(program, env)
39-
}
40-
4128
func Debug() *VM {
4229
vm := &VM{
4330
debug: true,

vm/vm_test.go

Lines changed: 2 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -18,35 +18,8 @@ import (
1818
)
1919

2020
func TestRun_NilProgram(t *testing.T) {
21-
t.Run("run with nil program", func(t *testing.T) {
22-
newVM, err := vm.Run(nil, nil)
23-
require.Error(t, err)
24-
require.Nil(t, newVM)
25-
})
26-
t.Run("run with nil program and nil config", func(t *testing.T) {
27-
newVM, err := vm.RunWithConfig(nil, nil, nil)
28-
require.Error(t, err)
29-
require.Nil(t, newVM)
30-
})
31-
t.Run("run with nil config", func(t *testing.T) {
32-
program, err := expr.Compile("1")
33-
require.Nil(t, err)
34-
newVM, err := vm.RunWithConfig(program, nil, nil)
35-
require.Error(t, err)
36-
require.Nil(t, newVM)
37-
})
38-
t.Run("run with config", func(t *testing.T) {
39-
program, err := expr.Compile("1")
40-
require.Nil(t, err)
41-
config := conf.New(nil)
42-
env := map[string]any{
43-
"a": 1,
44-
}
45-
config.MemoryBudget = 100
46-
newVM, err := vm.RunWithConfig(program, env, config)
47-
require.Nil(t, err)
48-
require.Equal(t, newVM, 1)
49-
})
21+
_, err := vm.Run(nil, nil)
22+
require.Error(t, err)
5023
}
5124

5225
func TestRun_ReuseVM(t *testing.T) {

0 commit comments

Comments
 (0)