Skip to content

Commit 181d116

Browse files
committed
Consistently quote build configuration names in diagnostics
1 parent 613c072 commit 181d116

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

Sources/SwiftIfConfig/IfConfigError.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ enum IfConfigError: Error, CustomStringConvertible {
4646
return "build configuration cannot handle '\(name)'"
4747

4848
case .requiresUnlabeledArgument(name: let name, role: let role, syntax: _):
49-
return "\(name) requires a single unlabeled argument for the \(role)"
49+
return "'\(name)' requires a single unlabeled argument for the \(role)"
5050

5151
case .unsupportedVersionOperator(name: let name, operator: let op):
5252
return "'\(name)' version check does not support operator '\(op.trimmedDescription)'"
@@ -69,13 +69,13 @@ enum IfConfigError: Error, CustomStringConvertible {
6969
return "compiler version must not have more than five components"
7070

7171
case .canImportMissingModule(syntax: _):
72-
return "canImport requires a module name"
72+
return "'canImport' requires a module name"
7373

7474
case .canImportLabel(syntax: _):
75-
return "second parameter of canImport should be labeled as _version or _underlyingVersion"
75+
return "second parameter of 'canImport' should be labeled as _version or _underlyingVersion"
7676

7777
case .canImportTwoParameters(syntax: _):
78-
return "canImport can take only two parameters"
78+
return "'canImport' can take only two parameters"
7979

8080
case .ignoredTrailingComponents(version: let version, syntax: _):
8181
return "trailing components of version '\(version.description)' are ignored"

Tests/SwiftIfConfigTest/EvaluateTests.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ public class EvaluateTests: XCTestCase {
314314
.unparsed,
315315
diagnostics: [
316316
DiagnosticSpec(
317-
message: "swift requires a single unlabeled argument for the version comparison (>= or <= a version)",
317+
message: "'swift' requires a single unlabeled argument for the version comparison (>= or <= a version)",
318318
line: 1,
319319
column: 1,
320320
severity: .error
@@ -374,7 +374,7 @@ public class EvaluateTests: XCTestCase {
374374
.unparsed,
375375
diagnostics: [
376376
DiagnosticSpec(
377-
message: #"second parameter of canImport should be labeled as _version or _underlyingVersion"#,
377+
message: #"second parameter of 'canImport' should be labeled as _version or _underlyingVersion"#,
378378
line: 1,
379379
column: 14,
380380
severity: .error
@@ -387,7 +387,7 @@ public class EvaluateTests: XCTestCase {
387387
.unparsed,
388388
diagnostics: [
389389
DiagnosticSpec(
390-
message: #"canImport can take only two parameters"#,
390+
message: #"'canImport' can take only two parameters"#,
391391
line: 1,
392392
column: 1,
393393
severity: .error

0 commit comments

Comments
 (0)