Skip to content

Commit 528804f

Browse files
committed
Updated CRAN comments
1 parent b3347ce commit 528804f

File tree

1 file changed

+22
-0
lines changed

1 file changed

+22
-0
lines changed

cran-comments.md

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,25 @@
55
* This is a new release.
66
* Checking installed package size ... NOTE installed size is 46.3Mb (linux-only)
77
* Possibly misspelled words in DESCRIPTION: All of the words are proper nouns or technical terms (BCF, Carvalho, Chipman, McCulloch, XBART)
8+
9+
## CRAN comments (20250206)
10+
11+
Below are responses to the initial comments received from CRAN on Feb 6, 2025
12+
13+
### Copyright
14+
15+
> Please always add all authors, contributors and copyright holders in the Authors@R field with the appropriate roles."
16+
17+
stochtree's C++ core has several vendored dependencies. The license and copyright details for each of these dependencies are delineated in the inst/COPYRIGHTS file. We have included the authors / contributors of each of these dependencies as copyright holders in the authors list of the DESCRIPTION file and also included a "Copyright:" section in the DESCRIPTION file explaining this.
18+
19+
### TRUE / FALSE
20+
21+
> Please write TRUE and FALSE instead of T and F.
22+
23+
We have converted `T` and `F` to `TRUE` and `FALSE` in the R code.
24+
25+
### Examples with commented code
26+
27+
> Some code lines in examples are commented out. Please never do that.
28+
29+
We no longer do this, and apologize for the oversight.

0 commit comments

Comments
 (0)