Merge pull request #153 from MichaelChirico/patch-1

andrewherren · web-flow · commit e0917408712a · 2025-02-27T01:08:58.000-06:00
Remove unused 'num_columns'
diff --git a/src/data.cpp b/src/data.cpp
@@ -70,9 +70,6 @@ ColumnVector::ColumnVector(std::string filename, int32_t column_index, bool head
     Log::Fatal("Could not recognize data format of %s", filename.c_str());
   }
   
-  // Determine number of columns in the data file
-  int num_columns = parser->NumFeatures();
-
   // Read data to memory
   auto text_data = LoadTextDataToMemory(filename.c_str(), &num_global_data, header);
   int num_observations = static_cast<data_size_t>(text_data.size());

Original file line number	Diff line number	Diff line change
`@@ -70,9 +70,6 @@ ColumnVector::ColumnVector(std::string filename, int32_t column_index, bool head`
`70`	`70`	`Log::Fatal("Could not recognize data format of %s", filename.c_str());`
`71`	`71`	`}`
`72`	`72`
`73`		`- // Determine number of columns in the data file`
`74`		`- int num_columns = parser->NumFeatures();`
`75`		`-`
`76`	`73`	`// Read data to memory`
`77`	`74`	`auto text_data = LoadTextDataToMemory(filename.c_str(), &num_global_data, header);`
`78`	`75`	`int num_observations = static_cast<data_size_t>(text_data.size());`