Skip to content

Commit e6e916f

Browse files
committed
Respond to review comments originally from llvm#134366
These changes were originally opened under llvm#134366 but were moved to this PR to allow me to drive further changes as I was the original author. This commit responds to comments made on the original PR.
1 parent a5b81d2 commit e6e916f

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

clang/docs/ReleaseNotes.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ Potentially Breaking Changes
3939
such as when performing member access on a '[[deprecated]]' type alias.
4040
(#GH58547)
4141
- For ARM targets, when using cc1as, the features included in the selected CPU or
42-
Arch's FPU are now loaded and utilized. If you wish not to use a specific feature,
43-
this will need appending to the command line used.
42+
Architecture's FPU are now loaded and utilized. If you wish not to use a specific feature,
43+
the relevant ``+no`` option will need to be amended to the command line option.
4444

4545
C/C++ Language Potentially Breaking Changes
4646
-------------------------------------------

clang/test/Driver/armv7-default-neon.s

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33

44
// REQUIRES: arm-registered-target
55
// RUN: %clang -c -target armv7-apple-darwin -o /dev/null %s
6+
// RUN: %clang -c -target armv7-apple-darwin -o /dev/null %s -### 2>&1 | FileCheck --check-prefix=CHECK-TARGET-FEATURES %s
67
// RUN: %clang -c -target armv7-windows -o /dev/null %s
8+
// RUN: %clang -c -target armv7-windows -o /dev/null %s -### 2>&1 | FileCheck --check-prefix=CHECK-TARGET-FEATURES %s
9+
10+
// CHECK-TARGET-FEATURES: "-target-feature" "+neon"
711

812
vadd.i32 q0, q0, q0

clang/test/Driver/armv7s-default-vfpv4.s

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,8 @@
22

33
// REQUIRES: arm-registered-target
44
// RUN: %clang -c -target armv7s-apple-darwin -o /dev/null %s
5+
// RUN: %clang -c -target armv7s-apple-darwin -o /dev/null %s -### 2>&1 | FileCheck --check-prefix=CHECK-TARGET-FEATURES %s
6+
7+
// CHECK-TARGET-FEATURES: "-target-feature" "+vfp4"
58

69
vfma.f32 q1, q2, q3

0 commit comments

Comments
 (0)