Skip to content

Commit 1ece4b1

Browse files
[fix]createWebPrintingJob处理params review by xiongjj
1 parent 6e946fb commit 1ece4b1

File tree

4 files changed

+25
-17
lines changed

4 files changed

+25
-17
lines changed

src/mapboxgl/services/WebPrintingJobService.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,10 @@ export class WebPrintingJobService extends ServiceBase {
4141
* @param {RequestCallback} callback - 回调函数。
4242
*/
4343
createWebPrintingJob(params, callback) {
44-
this._webPrintingService.createWebPrintingJob(params, callback);
44+
if (!params) {
45+
return;
46+
}
47+
this._webPrintingService.createWebPrintingJob(this._processParams(params), callback);
4548
}
4649

4750
/**

src/maplibregl/services/WebPrintingJobService.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,10 @@ export class WebPrintingJobService extends ServiceBase {
4040
* @param {RequestCallback} callback - 回调函数。
4141
*/
4242
createWebPrintingJob(params, callback) {
43-
this._webPrintingService.createWebPrintingJob(params, callback);
43+
if (!params) {
44+
return;
45+
}
46+
this._webPrintingService.createWebPrintingJob(this._processParams(params), callback);
4447
}
4548

4649
/**

test/leaflet/services/WebPrintingJobServiceSpec.js

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -60,22 +60,23 @@ describe('leaflet_WebPrintingJobService', () => {
6060
expect(options).not.toBeNull();
6161
return Promise.resolve(new Response(JSON.stringify(createWebPringintJobResultJson)));
6262
});
63+
jobService.createWebPrintingJob(null);
6364
jobService.createWebPrintingJob(param, (serviceResult) => {
64-
try {
65-
expect(jobService).not.toBeNull();
66-
expect(serviceResult).not.toBeNull();
67-
expect(serviceResult.type).toEqual('processCompleted');
68-
expect(serviceResult.result[0].resourceConfigID).not.toBeNull();
69-
expect(serviceResult.result[0].path).toEqual(url + '/jobs/' + serviceResult.result[0].resourceConfigID);
70-
expect(serviceResult.result[0].name).toEqual(serviceResult.result[0].resourceConfigID);
71-
done();
72-
} catch (e) {
73-
console.log("'createWebPrintingJob'案例失败" + e.name + ':' + e.message);
74-
expect(false).toBeTruthy();
75-
jobService.destroy();
76-
done();
77-
}
78-
});
65+
try {
66+
expect(jobService).not.toBeNull();
67+
expect(serviceResult).not.toBeNull();
68+
expect(serviceResult.type).toEqual('processCompleted');
69+
expect(serviceResult.result[0].resourceConfigID).not.toBeNull();
70+
expect(serviceResult.result[0].path).toEqual(url + '/jobs/' + serviceResult.result[0].resourceConfigID);
71+
expect(serviceResult.result[0].name).toEqual(serviceResult.result[0].resourceConfigID);
72+
done();
73+
} catch (e) {
74+
console.log("'createWebPrintingJob'案例失败" + e.name + ':' + e.message);
75+
expect(false).toBeTruthy();
76+
jobService.destroy();
77+
done();
78+
}
79+
});
7980
});
8081

8182
it('getPrintingJob', (done) => {

test/maplibregl/services/WebPrintingJobServiceSpec.js

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)