Skip to content

Commit a1f5030

Browse files
修复threelayer 错误调用this.renderer review by luox
1 parent 44dfbb2 commit a1f5030

File tree

3 files changed

+5
-11
lines changed

3 files changed

+5
-11
lines changed

src/common/overlay/threejs/ThreeLayerRenderer.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ export class ThreeLayerRenderer {
267267
if (coordinate && object3D) {
268268
this.setPosition(object3D, coordinate);
269269
}
270-
this.renderer && this.renderer.scene.add(object3D);
270+
this.scene.add(object3D);
271271
}
272272

273273
/**
@@ -276,7 +276,7 @@ export class ThreeLayerRenderer {
276276
* @returns {ThreeLayer} ThreeLayer的实例对象。
277277
*/
278278
clearMesh() {
279-
let scene = this.renderer.scene;
279+
let scene = this.scene;
280280
if (!scene) {
281281
return this;
282282
}
@@ -295,7 +295,7 @@ export class ThreeLayerRenderer {
295295
* @returns {ThreeLayer} ThreeLayer的实例对象。
296296
*/
297297
clearAll(clearCamera) {
298-
let scene = this.renderer.scene;
298+
let scene = this.scene;
299299
if (!scene) {
300300
return this;
301301
}

src/mapboxgl/overlay/ThreeLayer.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,10 +123,7 @@ export class ThreeLayer extends mapboxgl.Evented {
123123
* @returns {ThreeLayer} ThreeLayer的实例对象。
124124
*/
125125
addObject(object3D, coordinate) {
126-
if (coordinate && object3D) {
127-
this.setPosition(object3D, coordinate);
128-
}
129-
this.renderer && this.renderer.scene.add(object3D);
126+
this.renderer && this.renderer.addObject(object3D, coordinate);
130127
}
131128

132129
/**

src/maplibregl/overlay/ThreeLayer.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,7 @@ export class ThreeLayer extends maplibregl.Evented {
9595
* @returns {ThreeLayer} ThreeLayer的实例对象。
9696
*/
9797
addObject(object3D, coordinate) {
98-
if (coordinate && object3D) {
99-
this.setPosition(object3D, coordinate);
100-
}
101-
this.renderer && this.renderer.scene.add(object3D);
98+
this.renderer && this.renderer.addObject(object3D, coordinate);
10299
}
103100

104101
/**

0 commit comments

Comments
 (0)