Fix ambiguity test of SignedMultiplicativeInverse

Author: MilesCranmer

src/disambiguities.jl

@@ -14,9 +14,7 @@ Base.:/(l::AbstractDimensions, r::Number) = error("Please use an `UnionAbstractQ
 Base.:/(l::Number, r::AbstractDimensions) = error("Please use an `UnionAbstractQuantity` for division. You used division on types: $(typeof(l)) and $(typeof(r)).")
 
 if VERSION < v"1.7"
-    for I in (Base.MultiplicativeInverses.UnsignedMultiplicativeInverse, Base.MultiplicativeInverses.SignedMultiplicativeInverse)
-        @eval function Base.div(x::T, y::$I{T}, r::RoundingMode=RoundToZero) where {T<:AbstractGenericQuantity}
-            return new_quantity(typeof(x), div(ustrip(x), y, r), dimension(x))
-        end
+    @eval function Base.div(x::DynamicQuantities.AbstractGenericQuantity{T}, y::T) where {T}
+        return new_quantity(typeof(x), div(ustrip(x), y), dimension(x))
     end
-end
+end

test/unittests.jl

@@ -757,6 +757,16 @@ end
     y = x ^ (3//2)
     @test y == Quantity(1.0, length=3//2)
     @test typeof(y) == Quantity{Float64,DEFAULT_DIM_TYPE}
+
+    VERSION < v"1.7" && for I in (Int64, UInt64)
+        x = GenericQuantity{I}(1u"km/s")
+        a = (
+            I <: Signed ? 
+            Base.MultiplicativeInverses.SignedMultiplicativeInverse :
+            Base.MultiplicativeInverses.UnsignedMultiplicativeInverse
+        )(I(3))
+        @test div(x, a) == GenericQuantity{I}(333u"m/s")
+    end
 end
 
 for Q in (Quantity, GenericQuantity)