fix: Support for negative values #284 (#291)

RichardNolan · Richard Nolan · web-flow · commit df31cad7a5cc · 2022-07-05T18:26:19.000-06:00
start from negative value rather than 0 and end at 0
if secondaryValue&lt;0

Co-authored-by: Richard Nolan &lt;richard.nolan@intellync.com&gt;
diff --git a/src/seriesTypes/Bar.tsx b/src/seriesTypes/Bar.tsx
@@ -192,7 +192,10 @@ function getSecondaryStart<TDatum>(
     return secondaryAxis.scale(datum.stackData?.[0] ?? NaN) ?? NaN
   }
 
-  return secondaryAxis.scale(0) ?? NaN
+  return (
+    secondaryAxis.scale(datum.secondaryValue < 0 ? datum.secondaryValue : 0) ??
+    NaN
+  )
 }
 
 function getSecondary<TDatum>(
@@ -203,7 +206,10 @@ function getSecondary<TDatum>(
     return secondaryAxis.scale(datum.stackData?.[1] ?? NaN) ?? NaN
   }
 
-  return secondaryAxis.scale(datum.secondaryValue) ?? NaN
+  return (
+    secondaryAxis.scale(datum.secondaryValue < 0 ? 0 : datum.secondaryValue) ??
+    NaN
+  )
 }
 
 function clampPxToAxis<TDatum>(

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,10 @@ function getSecondaryStart<TDatum>(`
`192`	`192`	`return secondaryAxis.scale(datum.stackData?.[0] ?? NaN) ?? NaN`
`193`	`193`	`}`
`194`	`194`
`195`		`- return secondaryAxis.scale(0) ?? NaN`
	`195`	`+ return (`
	`196`	`+ secondaryAxis.scale(datum.secondaryValue < 0 ? datum.secondaryValue : 0) ??`
	`197`	`+ NaN`
	`198`	`+ )`
`196`	`199`	`}`
`197`	`200`
`198`	`201`	`function getSecondary<TDatum>(`
`@@ -203,7 +206,10 @@ function getSecondary<TDatum>(`
`203`	`206`	`return secondaryAxis.scale(datum.stackData?.[1] ?? NaN) ?? NaN`
`204`	`207`	`}`
`205`	`208`
`206`		`- return secondaryAxis.scale(datum.secondaryValue) ?? NaN`
	`209`	`+ return (`
	`210`	`+ secondaryAxis.scale(datum.secondaryValue < 0 ? 0 : datum.secondaryValue) ??`
	`211`	`+ NaN`
	`212`	`+ )`
`207`	`213`	`}`
`208`	`214`
`209`	`215`	`function clampPxToAxis<TDatum>(`