MsieJavaScriptEngine.ActiveScript.ActiveScriptException not wrapped

[Daniel15]

The MSIE engine catches MsieJavaScriptEngine.JsRuntimeExceptions but does not catch MsieJavaScriptEngine.ActiveScript.ActiveScriptExceptions (which can occur if there's a syntax error). These should be wrapped in an appropriate exception class. This exception type is internal so I can't even catch them to handle them nicely at the moment.

Additionally, why is the MsieJsEngine class sealed? This makes it a lot more difficult to add custom behaviour without forking the project.

[Taritsyn]

Hello, Daniel!

MsieJavaScriptEngine.ActiveScript.ActiveScriptException are catched (see ActiveScriptJsEngineBase.cs file).

MsieJsEngine class is sealed, because I see no point in inheritance from it.

Give an example of custom behaviour.

[Daniel15]

Hey @Taritsyn, it looks like CallFunction doesn't wrap exceptions:

using System;
using JavaScriptEngineSwitcher.Core;
using JavaScriptEngineSwitcher.Msie;
using JavaScriptEngineSwitcher.Msie.Configuration;

namespace ConsoleApplication9
{
    class Program
    {
        static void Main(string[] args)
        {
            var config = new MsieConfiguration { EngineMode = JsEngineMode.ChakraActiveScript };
            using (var engine = new MsieJsEngine(config))
            {
                engine.Execute("function foo() { throw new Error('Hello World'); }");
                try
                {
                    var result = engine.CallFunction<string>("foo", "bar");
                }
                catch (JsRuntimeException)
                {
                    Console.WriteLine("Caught JsRuntimeException :)");
                }
                catch (Exception ex)
                {
                    Console.WriteLine("Caught {0}", ex.GetType());
                    if (ex.InnerException != null)
                    {
                        Console.WriteLine(" --> {0}", ex.InnerException.GetType());
                    }
                }
            }
            Console.ReadKey();
        }
    }
}

Result:

Caught System.Reflection.TargetInvocationException
 --> MsieJavaScriptEngine.ActiveScript.ActiveScriptException

My custom behaviour was going to be wrapping the exceptions in a derived class, so I didn't have to modify MsieJavaScriptEngine itself. I guess it's not common. I just dislike sealed classes :)

[Taritsyn]

This bug fixed in the JavaScriptEngineSwitcher.Msie v1.1.6.

[Daniel15]

Thank you @Taritsyn! :)