Skip to content

Support for ContentResult #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Nov 18, 2013 · 7 comments
Closed

Support for ContentResult #12

ghost opened this issue Nov 18, 2013 · 7 comments

Comments

@ghost
Copy link

ghost commented Nov 18, 2013

Looks like current version does not support Content result.

@robdmoore
Copy link
Member

Hey mate,

Thanks for raising those issues. It's been a busy week so I haven't had time to respond yet, but I will do.

In the meantime have you looked at the ShouldRenderFile method? It doesn't deal with ContentResult, but rather FileContentResult, which extends ContentResult from memory.

Also, check out #3 for my vision about the full array of methods I think should be in there. It should be pretty easy to follow what's there so feel free to submit a PR for any of the methods you particularly need if you don't want to wait for me to get around it. That issue is marked with the "Jump In" tag as explained here: http://docs.teststack.net/Contributing.html (so should be ripe for the picking)

@ghost
Copy link
Author

ghost commented Nov 20, 2013

Great!
I will have a look at those.

Thanks for your interest mate!

@robdmoore
Copy link
Member

Did you have any luck checking it out? Keen to assist any way I can if you are willing to work on it :)

@emzyme20
Copy link

emzyme20 commented Apr 3, 2014

Hi,

Has anyone looked into adding support for Content result? This post is 5 months old but I can't see any updates to releases.

@robdmoore
Copy link
Member

Not too my knowledge

@robdmoore
Copy link
Member

Oops to not too!

@robdmoore
Copy link
Member

This has now been added :) Thanks @byteblast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants