Merge branch 'master' into do_not_suppress_try

Author: vil02

pmd-exclude.properties

@@ -25,7 +25,6 @@ com.thealgorithms.datastructures.queues.PriorityQueue=UselessParentheses
 com.thealgorithms.datastructures.stacks.NodeStack=UnnecessaryFullyQualifiedName,UnusedFormalParameter
 com.thealgorithms.datastructures.stacks.StackArray=UselessParentheses
 com.thealgorithms.datastructures.trees.CheckBinaryTreeIsValidBST=UselessParentheses
-com.thealgorithms.datastructures.trees.Point=OverrideBothEqualsAndHashcode
 com.thealgorithms.datastructures.trees.SegmentTree=UselessParentheses
 com.thealgorithms.devutils.nodes.LargeTreeNode=UselessParentheses
 com.thealgorithms.devutils.nodes.SimpleNode=UselessParentheses

pom.xml

@@ -79,10 +79,8 @@
                         <arg>-Xlint:all</arg>
                         <arg>-Xlint:-auxiliaryclass</arg>
                         <arg>-Xlint:-rawtypes</arg>
-                        <arg>-Xlint:-serial</arg>
                         <arg>-Xlint:-unchecked</arg>
                         <arg>-Xlint:-lossy-conversions</arg>
-                        <arg>-Xlint:-this-escape</arg>
                         <arg>-Werror</arg>
                     </compilerArgs>
                 </configuration>

spotbugs-exclude.xml

@@ -80,9 +80,6 @@
     <Match>
         <Bug pattern="SS_SHOULD_BE_STATIC" />
     </Match>
-    <Match>
-        <Bug pattern="HE_EQUALS_USE_HASHCODE" />
-    </Match>
     <Match>
         <Bug pattern="IT_NO_SUCH_ELEMENT" />
     </Match>

src/main/java/com/thealgorithms/ciphers/RSA.java

@@ -47,7 +47,7 @@ public synchronized BigInteger decrypt(BigInteger encryptedMessage) {
     /**
      * Generate a new public and private key set.
      */
-    public synchronized void generateKeys(int bits) {
+    public final synchronized void generateKeys(int bits) {
         SecureRandom r = new SecureRandom();
         BigInteger p = new BigInteger(bits / 2, 100, r);
         BigInteger q = new BigInteger(bits / 2, 100, r);

src/main/java/com/thealgorithms/datastructures/heaps/MaxHeap.java

@@ -91,7 +91,7 @@ private HeapElement extractMax() {
     }
 
     @Override
-    public void insertElement(HeapElement element) {
+    public final void insertElement(HeapElement element) {
         maxHeap.add(element);
         toggleUp(maxHeap.size());
     }

src/main/java/com/thealgorithms/datastructures/heaps/MinHeap.java

@@ -85,7 +85,7 @@ private HeapElement extractMin() {
     }
 
     @Override
-    public void insertElement(HeapElement element) {
+    public final void insertElement(HeapElement element) {
         minHeap.add(element);
         toggleUp(minHeap.size());
     }

src/main/java/com/thealgorithms/datastructures/lists/DoublyLinkedList.java

@@ -13,7 +13,7 @@
  *
  * @author Unknown
  */
-public class DoublyLinkedList {
+public final class DoublyLinkedList {
 
     /**
      * Head refers to the front of the list

src/main/java/com/thealgorithms/datastructures/trees/SegmentTree.java

@@ -19,7 +19,7 @@ public SegmentTree(int n, int[] arr) {
     }
 
     /* A function which will create the segment tree*/
-    public int constructTree(int[] arr, int start, int end, int index) {
+    public final int constructTree(int[] arr, int start, int end, int index) {
         if (start == end) {
             this.seg_t[index] = arr[start];
             return arr[start];

src/main/java/com/thealgorithms/sorts/TopologicalSort.java

@@ -73,13 +73,6 @@ public void addEdge(String label, String... next) {
         }
     }
 
-    static class BackEdgeException extends RuntimeException {
-
-        BackEdgeException(String backEdge) {
-            super("This graph contains a cycle. No linear ordering is possible. " + backEdge);
-        }
-    }
-
     /*
      * Depth First Search
      *
@@ -131,7 +124,7 @@ private static String sort(Graph graph, Vertex u, LinkedList<String> list) {
                  *
                  * In many cases, we will not know u.f, but v.color denotes the type of edge
                  * */
-                throw new BackEdgeException("Back edge: " + u.label + " -> " + label);
+                throw new RuntimeException("This graph contains a cycle. No linear ordering is possible. Back edge: " + u.label + " -> " + label);
             }
         });
         u.color = Color.BLACK;

src/test/java/com/thealgorithms/sorts/TopologicalSortTest.java

@@ -4,7 +4,6 @@
 import static org.junit.jupiter.api.Assertions.assertIterableEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
-import com.thealgorithms.sorts.TopologicalSort.BackEdgeException;
 import com.thealgorithms.sorts.TopologicalSort.Graph;
 import java.util.LinkedList;
 import org.junit.jupiter.api.Test;
@@ -55,7 +54,7 @@ public void failureTest() {
         graph.addEdge("6", "2");
         graph.addEdge("7", "");
         graph.addEdge("8", "");
-        Exception exception = assertThrows(BackEdgeException.class, () -> TopologicalSort.sort(graph));
+        Exception exception = assertThrows(RuntimeException.class, () -> TopologicalSort.sort(graph));
         String expected = "This graph contains a cycle. No linear ordering is possible. "
             + "Back edge: 6 -> 2";
         assertEquals(exception.getMessage(), expected);