Skip to content

Refactor Sudoku implementation #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2024

Conversation

sozelfist
Copy link
Contributor

Description

  • Create sudoku_solver function to hide states of SudokuSolver class
  • Rename variables to make code more readable
  • Rewrite tests using macros
  • Remove print_board method.

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

- Create `sudoku_solver` function to hide states of `SudokuSolver` class
- Rename variables to make code more readable
- Rewrite tests using macros
- Remove `print_board` method
@sozelfist sozelfist requested review from imp2002 and vil02 as code owners May 13, 2024 08:05
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (1020ea2) to head (e1b9278).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
+ Coverage   94.77%   94.90%   +0.12%     
==========================================
  Files         298      301       +3     
  Lines       22194    22344     +150     
==========================================
+ Hits        21035    21206     +171     
+ Misses       1159     1138      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sozelfist sozelfist force-pushed the ref/backtracking/sudoku branch from d3c0c05 to e1b9278 Compare May 20, 2024 02:53
@vil02 vil02 changed the title ref: refactor Sudoku implementation Refactor Sudoku implementation May 22, 2024
@vil02 vil02 merged commit bba0b0d into TheAlgorithms:master May 22, 2024
4 checks passed
@sozelfist sozelfist deleted the ref/backtracking/sudoku branch May 22, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants