Implement Hamiltonian Cycle Finder #731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #731 +/- ##
==========================================
+ Coverage 94.95% 94.96% +0.01%
==========================================
Files 303 304 +1
Lines 22533 22584 +51
==========================================
+ Hits 21396 21447 +51
Misses 1137 1137 ☔ View full report in Codecov by Sentry. |
|
Can you have a look on this PR (and other PRs in the backtracking category) and review them @vil02. |
|
Can you review this PR, @vil02? |
vil02
requested changes
Jun 18, 2024
vil02
requested changes
Jun 19, 2024
|
Failing CI will be fixed by #754. |
sozelfist
force-pushed
the
feat/backtracking/hamiltonian_cycle
branch
from
27e5351 to
300fb32
Compare
vil02
requested changes
Jun 20, 2024
- Add custom error `AdjMatError` type with 3 varients: `EmptyMat`, `StartOutOfBound` and `ImproperMat` - Add tests for exceptional cases - Change adjaceny matrix repr to `Vec<Vec<bool>>`
- Move error handling to appropriate methods - Add `num_vertices` method
sozelfist
force-pushed
the
feat/backtracking/hamiltonian_cycle
branch
from
300fb32 to
559b865
Compare
- Rename custom error to more related name, from `AdjMatError` to `FindHamiltonialCycleError` - Use `HashSet` to retrieve visited vextex in `O(1)` time - Chain method when propagating error - Add test for directed graph
vil02
requested changes
Jun 21, 2024
- Write error names in full word format - Use `Vec<bool>` to store visited vertices - Represent path as `Vec<Option<usize>>` where the undefined vertex is represented as `None` - Add suggested tests
vil02
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
See details in the implementation
Type of change
Checklist:
cargo clippy --all -- -D warningsjust before my last commit and fixed any issue that was found.cargo fmtjust before my last commit.cargo testjust before my last commit and all tests passed.mod.rsfile within its own folder, and in any parent folder(s).DIRECTORY.mdwith the correct link.COUNTRIBUTING.mdand my code follows its guidelines.