Implement Graph Coloring using Backtracking #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #737 +/- ##
==========================================
+ Coverage 95.04% 95.05% +0.01%
==========================================
Files 305 306 +1
Lines 22674 22736 +62
==========================================
+ Hits 21550 21612 +62
Misses 1124 1124 ☔ View full report in Codecov by Sentry. |
- Use `Vec<Vec<bool>>` to represent the adjacency matrix to make the code more readable and slightly more efficient in terms of memory usage. - Use `std::mem::take` to avoid unnecessary cloning while maintaining the original behavior of the algorithm - Add some edge tests
|
Can you help a look on this PR, @vil02? |
vil02
requested changes
Jun 27, 2024
8 tasks
- Add custom error `GraphColoringError` to handle the exceptional cases where the graph is empty or not squared - Adjust the `is_valid_color` method to make the implementation handle the directed graphs - Add tests for directed graphs
|
Let's have a look, @vil02? |
vil02
requested changes
Jun 30, 2024
|
Let's have a final look, @vil02. |
vil02
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See in the implementation.
Type of change
Checklist:
cargo clippy --all -- -D warningsjust before my last commit and fixed any issue that was found.cargo fmtjust before my last commit.cargo testjust before my last commit and all tests passed.mod.rsfile within its own folder, and in any parent folder(s).DIRECTORY.mdwith the correct link.COUNTRIBUTING.mdand my code follows its guidelines.