Skip to content

style: include range_plus_one #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Feb 4, 2025

Pull Request Template

Description

This PR removes include_range_plus_one from the list of from the list of suppressed lints.

I am not fully happy with the changes in https://github.com/TheAlgorithms/Rust/blob/8049c34fdeb72bd0b0ef455e0fb5c9ca9c3d5e19/src/data_structures/lazy_segment_tree.rs.

Continuation of #743.

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.49%. Comparing base (8049c34) to head (1ed4f72).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #869   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files         316      316           
  Lines       22910    22919    +9     
=======================================
+ Hits        21878    21887    +9     
  Misses       1032     1032           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 requested a review from siriak February 4, 2025 07:39
@vil02 vil02 marked this pull request as ready for review February 4, 2025 07:39
@vil02 vil02 requested a review from imp2002 as a code owner February 4, 2025 07:39
@siriak siriak merged commit ae10da6 into TheAlgorithms:master Feb 4, 2025
4 checks passed
@vil02 vil02 deleted the include_range_plus_one branch February 27, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants