ext/gmp: Fix leading whitespace before explicit octal prefix

Author: Girgias

ext/gmp/gmp.c

@@ -583,7 +583,13 @@ static zend_result convert_zstr_to_gmp(mpz_t gmp_number, const zend_string *val,
 	const char *num_str = ZSTR_VAL(val);
 	bool skip_lead = false;
 
-	if (ZSTR_LEN(val) >= 2 && num_str[0] == '0') {
+	size_t num_len = ZSTR_LEN(val);
+	while (isspace(*num_str)) {
+		++num_str;
+		--num_len;
+	}
+
+	if (num_len >= 2 && num_str[0] == '0') {
 		if ((base == 0 || base == 16) && (num_str[1] == 'x' || num_str[1] == 'X')) {
 			base = 16;
 			skip_lead = true;

ext/gmp/tests/gmp_init_leading_spaces.phpt

@@ -0,0 +1,61 @@
+--TEST--
+gmp_init() with various integer notations and leading spaces
+--EXTENSIONS--
+gmp
+--FILE--
+<?php
+
+var_dump(gmp_init("  0x16"));
+var_dump(gmp_init("  0X16"));
+var_dump(gmp_init("  0o16"));
+var_dump(gmp_init("  0o16"));
+var_dump(gmp_init("  016"));
+var_dump(gmp_init("  016"));
+var_dump(gmp_init("  0b11"));
+var_dump(gmp_init("  0b11"));
+var_dump(gmp_init("  0"));
+try {
+    var_dump(gmp_init("  "));
+} catch (\Throwable $e) {
+    echo $e::class, ': ', $e->getMessage(), PHP_EOL;
+}
+
+?>
+--EXPECT--
+object(GMP)#1 (1) {
+  ["num"]=>
+  string(2) "22"
+}
+object(GMP)#1 (1) {
+  ["num"]=>
+  string(2) "22"
+}
+object(GMP)#1 (1) {
+  ["num"]=>
+  string(2) "14"
+}
+object(GMP)#1 (1) {
+  ["num"]=>
+  string(2) "14"
+}
+object(GMP)#1 (1) {
+  ["num"]=>
+  string(2) "14"
+}
+object(GMP)#1 (1) {
+  ["num"]=>
+  string(2) "14"
+}
+object(GMP)#1 (1) {
+  ["num"]=>
+  string(1) "3"
+}
+object(GMP)#1 (1) {
+  ["num"]=>
+  string(1) "3"
+}
+object(GMP)#1 (1) {
+  ["num"]=>
+  string(1) "0"
+}
+ValueError: gmp_init(): Argument #1 ($num) is not an integer string