Fix validators

Author: josefhruska

auth/src/main/java/com/firebase/ui/auth/ui/email/CheckEmailFragment.java

@@ -253,7 +253,7 @@ private void showEmailAutoCompleteHint() {
 
     private void checkEmailValid() {
         if (getView() != null && mEmailFieldValidator != null) {
-            if (!mEmailFieldValidator.isValid()) {
+            if (!mEmailFieldValidator.isValid(mEmailEditText.getText().toString())) {
                 getView().findViewById(R.id.button_next).setBackgroundColor(ContextCompat.getColor(getContext(), R.color.sign_up_disabled));
             } else {
                 getView().findViewById(R.id.button_next).setBackgroundColor(ContextCompat.getColor(getContext(), R.color.authui_colorAccent));

auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailFragment.java

@@ -277,7 +277,7 @@ public void onClick(View view) {
     private void checkAllFieldsValid() {
         if (getView() != null) {
             TextView buttonSignUp = (TextView) getView().findViewById(R.id.button_create);
-            if (mEmailFieldValidator.isValid() && mPasswordFieldValidator.isValid() && mNameValidator.isValid()) {
+            if (mEmailFieldValidator.isValid(mEmailEditText.getText().toString()) && mPasswordFieldValidator.isValid(mPasswordEditText.getText().toString()) && mNameValidator.isValid(mNameEditText.getText().toString())) {
                 buttonSignUp.setBackgroundColor(ContextCompat.getColor(getContext(), R.color.authui_colorAccent));
             } else if (buttonSignUp != null) {
                 buttonSignUp.setBackgroundColor(ContextCompat.getColor(getContext(), R.color.sign_up_disabled));

auth/src/main/java/com/firebase/ui/auth/ui/email/fieldvalidators/EmailFieldValidator.java

@@ -22,21 +22,15 @@
 
 public class EmailFieldValidator extends BaseValidator {
 
-    private Boolean mIsValid = false;
-
     public EmailFieldValidator(TextInputLayout errorContainer) {
         super(errorContainer);
         mErrorMessage = mErrorContainer.getResources().getString(R.string.invalid_email_address);
         mEmptyMessage = mErrorContainer.getResources().getString(R.string.missing_email_address);
     }
 
     @Override
-    protected boolean isValid(CharSequence charSequence) {
-        mIsValid = Patterns.EMAIL_ADDRESS.matcher(charSequence).matches();
-        return mIsValid;
+    public boolean isValid(CharSequence charSequence) {
+        return Patterns.EMAIL_ADDRESS.matcher(charSequence).matches();
     }
 
-    public boolean isValid() {
-        return mIsValid;
-    }
 }

auth/src/main/java/com/firebase/ui/auth/ui/email/fieldvalidators/PasswordFieldValidator.java

@@ -20,8 +20,6 @@
 
 public class PasswordFieldValidator extends BaseValidator {
     private int mMinLength;
-    private Boolean mIsValid = false;
-
 
     public PasswordFieldValidator(TextInputLayout errorContainer, int minLength) {
         super(errorContainer);
@@ -31,12 +29,8 @@ public PasswordFieldValidator(TextInputLayout errorContainer, int minLength) {
     }
 
     @Override
-    protected boolean isValid(CharSequence charSequence) {
-        mIsValid = charSequence.length() >= mMinLength;
-        return mIsValid;
+    public boolean isValid(CharSequence charSequence) {
+        return charSequence.length() >= mMinLength;
     }
 
-    public boolean isValid() {
-        return mIsValid;
-    }
 }

auth/src/main/java/com/firebase/ui/auth/ui/email/fieldvalidators/RequiredFieldValidator.java

@@ -20,20 +20,14 @@
 
 public class RequiredFieldValidator extends BaseValidator {
 
-    private Boolean mIsValid = false;
-
     public RequiredFieldValidator(TextInputLayout errorContainer) {
         super(errorContainer);
         mErrorMessage = mErrorContainer.getResources().getString(R.string.required_field);
     }
 
     @Override
-    protected boolean isValid(CharSequence charSequence) {
-        mIsValid = charSequence != null && charSequence.length() > 0;
-        return mIsValid;
+    public boolean isValid(CharSequence charSequence) {
+        return charSequence != null && charSequence.length() > 0;
     }
 
-    public boolean isValid() {
-        return mIsValid;
-    }
 }