CR fix firebase#3

Author: josefhruska

app/src/main/res/values/styles.xml

@@ -6,7 +6,7 @@
         <item name="colorAccent">@color/colorAccent</item>
     </style>
 
-    <style name="AppTheme.NoToolbar" parent="Theme.AppCompat.Light.NoActionBar">
+    <style name="AppTheme.NoToolbar">
         <item name="windowActionBar">false</item>
         <item name="windowNoTitle">true</item>
     </style>

auth/src/main/java/com/firebase/ui/auth/ui/email/CheckEmailFragment.java

@@ -147,6 +147,7 @@ public void onActivityCreated(@Nullable Bundle savedInstanceState) {
         if (savedInstanceState != null) {
             return;
         }
+
         // Check for email
         String email = getArguments().getString(ExtraConstants.EXTRA_EMAIL);
         if (!TextUtils.isEmpty(email)) {

auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailActivity.java

@@ -20,7 +20,6 @@
 import android.support.annotation.RestrictTo;
 import android.support.design.widget.TextInputLayout;
 import android.support.v4.app.FragmentTransaction;
-import android.support.v7.widget.Toolbar;
 
 import com.firebase.ui.auth.IdpResponse;
 import com.firebase.ui.auth.R;
@@ -145,5 +144,4 @@ private void setSlideAnimation() {
         // Make the next activity slide in
         overridePendingTransition(R.anim.slide_in_right, R.anim.slide_out_left);
     }
-
 }

auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailFragment.java

@@ -92,16 +92,6 @@ public void onCreate(@Nullable Bundle savedInstanceState) {
         }
     }
 
-    @Override
-    public void onViewCreated(View view, @Nullable Bundle savedInstanceState) {
-        super.onViewCreated(view, savedInstanceState);
-        if (!mPasswordInput.isHintAnimationEnabled()) {
-            mPasswordInput.setHintAnimationEnabled(true);
-            ((TextInputLayout) getView().findViewById(R.id.name_layout)).setHintAnimationEnabled(true);
-            mEmailInput.setHintAnimationEnabled(true);
-        }
-    }
-
     @Nullable
     @Override
     public View onCreateView(LayoutInflater inflater,

auth/src/main/java/com/firebase/ui/auth/ui/email/fieldvalidators/EmailFieldValidator.java

@@ -32,5 +32,4 @@ public EmailFieldValidator(TextInputLayout errorContainer) {
     public boolean isValid(CharSequence charSequence) {
         return Patterns.EMAIL_ADDRESS.matcher(charSequence).matches();
     }
-
 }

auth/src/main/java/com/firebase/ui/auth/ui/email/fieldvalidators/PasswordFieldValidator.java

@@ -32,5 +32,4 @@ public PasswordFieldValidator(TextInputLayout errorContainer, int minLength) {
     public boolean isValid(CharSequence charSequence) {
         return charSequence.length() >= mMinLength;
     }
-
 }

auth/src/main/java/com/firebase/ui/auth/ui/email/fieldvalidators/RequiredFieldValidator.java

@@ -19,7 +19,6 @@
 import com.firebase.ui.auth.R;
 
 public class RequiredFieldValidator extends BaseValidator {
-
     public RequiredFieldValidator(TextInputLayout errorContainer) {
         super(errorContainer);
         mErrorMessage = mErrorContainer.getResources().getString(R.string.required_field);
@@ -29,5 +28,4 @@ public RequiredFieldValidator(TextInputLayout errorContainer) {
     public boolean isValid(CharSequence charSequence) {
         return charSequence != null && charSequence.length() > 0;
     }
-
 }

auth/src/main/res/drawable/idp_button_background_email.xml

@@ -2,8 +2,8 @@
 <selector xmlns:android="http://schemas.android.com/apk/res/android">
     <item>
         <shape android:shape="rectangle">
-            <corners android:radius="3dp" />
-            <solid android:color="#747474" />
+            <corners android:radius="3dp"/>
+            <solid android:color="#D0021B"/>
         </shape>
     </item>
 </selector>

auth/src/main/res/layout-land/auth_method_picker_layout.xml

@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
     android:clipToPadding="false"
@@ -32,7 +33,7 @@
     <RelativeLayout
         android:layout_width="0dp"
         android:layout_height="match_parent"
-        android:layout_weight="1">
+        android:layout_weight="1.0">
 
         <LinearLayout
             android:id="@+id/btn_holder"
@@ -51,6 +52,7 @@
                 android:layout_marginBottom="0dp"
                 android:layout_width="match_parent"
                 android:visibility="gone"
+                tools:visibility="visible"
                 android:layout_gravity="center"
                 android:text="@string/idp_name_email" />
 

auth/src/main/res/layout/check_email_layout.xml

@@ -27,7 +27,7 @@
 
     </android.support.design.widget.TextInputLayout>
 
-    <TextView
+    <Button
         android:id="@+id/button_next"
         style="@style/FirebaseUI.FullWidthButtonSettleUp"
         android:layout_alignParentBottom="true"

auth/src/main/res/layout/forgot_password_layout.xml

@@ -36,7 +36,7 @@
         android:gravity="end"
         android:paddingTop="194dp">
 
-        <TextView
+        <Button
             android:id="@+id/button_done"
             style="@style/FirebaseUI.FullWidthButtonSettleUp"
             android:text="@string/button_text_send" />

auth/src/main/res/layout/register_email_layout.xml

@@ -97,7 +97,7 @@
 
     </ScrollView>
 
-    <TextView
+    <Button
         android:id="@+id/button_create"
         style="@style/FirebaseUI.FullWidthButtonSettleUp"
         android:text="@string/sign_up" />

auth/src/main/res/layout/welcome_back_idp_prompt_layout.xml

@@ -2,9 +2,9 @@
 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools"
     style="@style/FirebaseUI.WrapperStyle"
-    android:orientation="vertical"
     android:paddingLeft="0dp"
-    android:paddingRight="0dp">
+    android:paddingRight="0dp"
+    android:orientation="vertical">
 
     <TextView
         android:paddingLeft="32dp"
@@ -20,7 +20,7 @@
         android:paddingRight="32dp"
         tools:text="Good news! You've already used [email protected]. Sign in with Google to continue to SuperApp" />
 
-    <TextView
+    <Button
         android:id="@+id/welcome_back_idp_button"
         style="@style/FirebaseUI.FullWidthButtonSettleUp"
         android:layout_alignParentBottom="true"

auth/src/main/res/layout/welcome_back_password_prompt_layout.xml

@@ -51,7 +51,7 @@
             android:layout_weight="1"
             android:text="@string/trouble_signing_in" />
 
-        <TextView
+        <Button
             android:id="@+id/button_done"
             style="@style/FirebaseUI.FullWidthButtonSettleUp"
             android:text="@string/sign_in_default" />

auth/src/main/res/values/styles.xml

@@ -247,11 +247,6 @@
         <item name="android:textColor">@color/gray_3</item>
     </style>
 
-    <style name="Toolbar" parent="@style/ThemeOverlay.AppCompat.ActionBar">
-        <!-- Customize color of navigation drawer icon and back arrow -->
-        <item name="colorControlNormal">@color/whiteColor</item>
-    </style>
-
     <style name="FirebaseUI.FullWidthButtonSettleUp" parent="FirebaseUI.Text">
         <item name="android:background">@drawable/ripple_background</item>
         <item name="android:fitsSystemWindows">true</item>

auth/src/test/java/com/firebase/ui/auth/ui/email/RecoverPasswordActivityTest.java

@@ -16,7 +16,6 @@
 
 import android.content.Intent;
 import android.widget.Button;
-import android.widget.TextView;
 
 import com.firebase.ui.auth.BuildConfig;
 import com.firebase.ui.auth.R;
@@ -61,7 +60,7 @@ private RecoverPasswordActivity createActivity() {
     @Config(shadows = {BaseHelperShadow.class, ActivityHelperShadow.class})
     public void testNextButton_sendsEmail() {
         RecoverPasswordActivity recoverPasswordActivity = createActivity();
-        TextView nextButton = (TextView) recoverPasswordActivity.findViewById(R.id.button_done);
+        Button nextButton = (Button) recoverPasswordActivity.findViewById(R.id.button_done);
         when(ActivityHelperShadow.sFirebaseAuth.sendPasswordResetEmail(TestConstants.EMAIL))
                 .thenReturn(new AutoCompleteTask<Void>(null, true, null));
         nextButton.performClick();

auth/src/test/java/com/firebase/ui/auth/ui/email/RegisterEmailActivityTest.java

@@ -19,7 +19,6 @@
 import android.support.design.widget.TextInputLayout;
 import android.widget.Button;
 import android.widget.EditText;
-import android.widget.TextView;
 
 import com.firebase.ui.auth.AuthUI;
 import com.firebase.ui.auth.BuildConfig;
@@ -80,7 +79,7 @@ public void testSignUpButton_validatesFields() {
         // Trigger RegisterEmailFragment (bypass check email)
         registerEmailActivity.onNewUser(new User.Builder(TestConstants.EMAIL).build());
 
-        TextView button = (TextView) registerEmailActivity.findViewById(R.id.button_create);
+        Button button = (Button) registerEmailActivity.findViewById(R.id.button_create);
         button.performClick();
 
         TextInputLayout nameLayout = (TextInputLayout)
@@ -142,7 +141,7 @@ public void testSignUpButton_successfulRegistrationShouldContinueToSaveCredentia
                         true,
                         null));
 
-        TextView button = (TextView) registerEmailActivity.findViewById(R.id.button_create);
+        Button button = (Button) registerEmailActivity.findViewById(R.id.button_create);
         button.performClick();
 
         TestHelper.verifySmartLockSave(

auth/src/test/java/com/firebase/ui/auth/ui/email/WelcomeBackPasswordPromptTest.java

@@ -18,7 +18,6 @@
 import android.support.design.widget.TextInputLayout;
 import android.widget.Button;
 import android.widget.EditText;
-import android.widget.TextView;
 
 import com.firebase.ui.auth.BuildConfig;
 import com.firebase.ui.auth.IdpResponse;
@@ -78,7 +77,7 @@ private WelcomeBackPasswordPrompt createActivity() {
     @Test
     public void testSignInButton_validatesFields() {
         WelcomeBackPasswordPrompt welcomeBack = createActivity();
-        TextView signIn = (TextView) welcomeBack.findViewById(R.id.button_done);
+        Button signIn = (Button) welcomeBack.findViewById(R.id.button_done);
         signIn.performClick();
         TextInputLayout passwordLayout =
                 (TextInputLayout) welcomeBack.findViewById(R.id.password_layout);
@@ -114,7 +113,7 @@ public void testSignInButton_signsInAndSavesCredentials() {
         when(mockFirebaseUser.getEmail()).thenReturn(TestConstants.EMAIL);
         when(mockFirebaseUser.getPhotoUrl()).thenReturn(TestConstants.PHOTO_URI);
 
-        TextView signIn = (TextView) welcomeBackActivity.findViewById(R.id.button_done);
+        Button signIn = (Button) welcomeBackActivity.findViewById(R.id.button_done);
         signIn.performClick();
 
         verify(ActivityHelperShadow.sFirebaseAuth).signInWithEmailAndPassword(