Skip to content

Commit 9ec7bb4

Browse files
author
josefhruska
committed
CR fix firebase#5
1 parent 1b077d6 commit 9ec7bb4

File tree

6 files changed

+16
-15
lines changed

6 files changed

+16
-15
lines changed

auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailActivity.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import android.support.design.widget.TextInputLayout;
2222
import android.support.v4.app.FragmentTransaction;
2323
import android.view.View;
24+
2425
import com.firebase.ui.auth.IdpResponse;
2526
import com.firebase.ui.auth.R;
2627
import com.firebase.ui.auth.ui.AppCompatBase;

auth/src/main/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ protected void onCreate(Bundle savedInstanceState) {
8585
if (logoId == AuthUI.NO_LOGO) {
8686
findViewById(R.id.logo_layout).setVisibility(View.GONE);
8787
} else {
88-
ImageView logo = (ImageView) findViewById(R.id.logo_layout);
88+
ImageView logo = (ImageView) findViewById(R.id.logo_layout); // We can't wrap this view into linear layout so we have to change its id to avoid conflicts in tests.
8989
logo.setImageResource(logoId);
9090
}
9191
}

auth/src/main/res/layout-land/auth_method_picker_layout.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
android:layout_height="match_parent"
3636
android:layout_weight="1.0">
3737

38+
3839
<LinearLayout
3940
android:id="@+id/btn_holder"
4041
style="@style/FirebaseUI.AuthMethodPicker.ButtonHolder"

auth/src/main/res/layout/activity_register_email.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<LinearLayout
3-
xmlns:android="http://schemas.android.com/apk/res/android"
2+
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
43
android:layout_width="match_parent"
54
android:layout_height="match_parent"
65
android:background="@color/white"

auth/src/main/res/layout/forgot_password_layout.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@
3939
android:paddingTop="194dp">
4040

4141
<Button
42-
android:id="@+id/button_done"
4342
style="@style/FirebaseUI.FullWidthButtonSettleUp"
43+
android:id="@+id/button_done"
4444
android:text="@string/button_text_send" />
4545

4646
</LinearLayout>

auth/src/main/res/layout/welcome_back_password_prompt_layout.xml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<LinearLayout
33
xmlns:android="http://schemas.android.com/apk/res/android"
4-
style="@style/FirebaseUI.WrapperStyle"
4+
android:orientation="vertical"
55
android:layout_width="match_parent"
66
android:layout_height="match_parent"
7-
android:orientation="vertical">
7+
style="@style/FirebaseUI.WrapperStyle">
88

99
<TextView
10-
style="@style/FirebaseUI.Text.Heading"
1110
android:layout_width="match_parent"
1211
android:layout_height="wrap_content"
12+
style="@style/FirebaseUI.Text.Heading"
1313
android:text="@string/welcome_back_email_header" />
1414

1515
<TextView
@@ -21,8 +21,8 @@
2121
android:layout_height="wrap_content">
2222

2323
<android.support.design.widget.TextInputLayout
24-
xmlns:app="http://schemas.android.com/apk/res-auto"
2524
android:id="@+id/password_layout"
25+
xmlns:app="http://schemas.android.com/apk/res-auto"
2626
style="@style/FirebaseUI.Text.TextInputLayout"
2727
android:layout_width="match_parent"
2828
android:layout_height="wrap_content"
@@ -32,31 +32,31 @@
3232
app:passwordToggleEnabled="true">
3333

3434
<android.support.design.widget.TextInputEditText
35-
android:id="@+id/password"
3635
style="@style/FirebaseUI.EditText.PasswordField"
37-
android:hint="@string/password_hint" />
36+
android:id="@+id/password"
37+
android:hint="@string/password_hint"/>
3838

3939
</android.support.design.widget.TextInputLayout>
4040

4141
</RelativeLayout>
4242

4343
<LinearLayout
44-
android:layout_width="match_parent"
4544
android:layout_height="wrap_content"
45+
android:layout_width="match_parent"
4646
android:paddingTop="16dp">
4747

4848
<TextView
4949
android:id="@+id/trouble_signing_in"
50-
style="@style/FirebaseUI.Text.Link"
50+
android:text="@string/trouble_signing_in"
5151
android:layout_width="0dp"
5252
android:layout_height="wrap_content"
5353
android:layout_weight="1"
54-
android:text="@string/trouble_signing_in" />
54+
style="@style/FirebaseUI.Text.Link"/>
5555

5656
<Button
57-
android:id="@+id/button_done"
5857
style="@style/FirebaseUI.FullWidthButtonSettleUp"
59-
android:text="@string/sign_in_default" />
58+
android:text="@string/sign_in_default"
59+
android:id="@+id/button_done"/>
6060

6161
</LinearLayout>
6262

0 commit comments

Comments
 (0)