Skip to content

Commit c1ff2cf

Browse files
authored
Rename upload artifact (#181)
* reference action by exact commit * reference render by full filepath * rename uploaded filename based on input filename
1 parent 976d69d commit c1ff2cf

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

.github/workflows/render.yml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,11 @@ jobs:
7676
key: latex-${{ inputs.input }}-${{ inputs.container-version }}-${{ github.run_id }}
7777
restore-keys: latex-${{ inputs.input }}-${{ inputs.container-version }}
7878

79+
# Note: It appears that we can't pass variables into 'uses:' below to allow callers to
80+
# request a version of the action. Referencing it by local path breaks external workflows
81+
# that call to this one.
82+
# The unfortunate workaround is for this file to be updated to point at specific commits
83+
# and reference that version of the action file in this reusable workflow.
7984
# Note: It appears that we can't pass variables into 'uses:' below to allow callers to
8085
# request a version of the action. Referencing it by local path breaks external workflows
8186
# that call to this one.
@@ -118,20 +123,21 @@ jobs:
118123
repo_token: ${{ secrets.GITHUB_TOKEN }}
119124
file: ${{ steps.gen_output_name.outputs.OUTPUT_FILENAME }}.*.pdf
120125
tag: ${{ github.ref }}
126+
asset_name: ${{ steps.gen_output_name.outputs.OUTPUT_FILENAME }}.pdf
121127
overwrite: true
122128
file_glob: true
123129
# Always upload all PDF and log files to the workflow artifacts
124130
- name: Upload pdfs
125-
uses: actions/upload-artifact@master
131+
uses: actions/upload-artifact@v4
126132
with:
127-
name: PDF
133+
name: ${{ steps.gen_output_name.outputs.OUTPUT_FILENAME }}.pdf
128134
path: |
129135
${{ steps.gen_output_name.outputs.OUTPUT_FILENAME }}.*.pdf
130136
if: always()
131137
- name: Upload logs
132-
uses: actions/upload-artifact@master
138+
uses: actions/upload-artifact@v4
133139
with:
134-
name: Logs
140+
name: ${{ steps.gen_output_name.outputs.OUTPUT_FILENAME }}.log
135141
path: |
136142
${{ steps.gen_output_name.outputs.OUTPUT_FILENAME }}.*.log
137143
if: always()

0 commit comments

Comments
 (0)