Skip to content

Replace resolve logic with tsconfig #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2015
Merged

Replace resolve logic with tsconfig #652

merged 1 commit into from
Oct 8, 2015

Conversation

blakeembrey
Copy link
Member

Closes #651. References #646.

Turns out it wasn't difficult to replace the parts you were using, and all the validation stays the same 😄

@blakeembrey
Copy link
Member Author

Actually, there's one thing missing - let me add that. It's not updating files.

Edit: Actually, it all works perfectly. There's a minor bug in tsconfig when you're only using negations - I realised this this morning with the other report, but good to know I don't have to fix it in two places.

@blakeembrey
Copy link
Member Author

@basarat Done. Made a new release with glob for tsconfig and only needed to change the prettyJSON output to go back to relative paths (making them "consistent" now too). I also added a feature to make sure indentation is persisted for tsconfig.json.

Edit: Speed++ 😄

@nycdotnet
Copy link
Contributor

Can you publish? If not would you like me to? Bas won't be on for several hours.

@blakeembrey
Copy link
Member Author

Sure, I can do it 👍

blakeembrey added a commit that referenced this pull request Oct 8, 2015
Replace resolve logic with `tsconfig`
@blakeembrey blakeembrey merged commit f1e699e into TypeStrong:master Oct 8, 2015
@blakeembrey
Copy link
Member Author

Done. v7.4.0.

@basarat
Copy link
Member

basarat commented Oct 8, 2015

Awesome. Thanks a ton for this .... I would have never managed to put in so much effort 🌹

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants