type check comparison test pack (#834)

* type check comparison test pack

Author: johnnyreilly

package.json

@@ -6,7 +6,7 @@
   "types": "dist/types/index.d.ts",
   "scripts": {
     "build": "tsc --version && tsc --project \"./src\"",
-    "comparison-tests": "npm link ./test/comparison-tests/testLib && node test/comparison-tests/run-tests.js",
+    "comparison-tests": "tsc --project \"./test/comparison-tests\" && npm link ./test/comparison-tests/testLib && node test/comparison-tests/run-tests.js",
     "comparison-tests-generate": "node test/comparison-tests/stub-new-version.js",
     "execution-tests": "npm i -g pnpm && node test/execution-tests/run-tests.js",
     "test": "node test/run-tests.js",
@@ -52,7 +52,7 @@
   },
   "devDependencies": {
     "@types/micromatch": "^3.1.0",
-    "@types/node": "^9.6.2",
+    "@types/node": "^10.0.0",
     "@types/semver": "^5.4.0",
     "babel": "^6.0.0",
     "babel-core": "^6.0.0",
@@ -62,7 +62,7 @@
     "babel-preset-es2016": "^6.16.0",
     "babel-preset-react": "^6.0.0",
     "escape-string-regexp": "^1.0.3",
-    "fs-extra": "^6.0.0",
+    "fs-extra": "^7.0.0",
     "glob": "^7.1.1",
     "html-webpack-plugin": "^3.2.0",
     "husky": "^0.14.3",

test/comparison-tests/create-and-execute-test.js

@@ -4,6 +4,7 @@ var path = require('path');
 var mkdirp = require('mkdirp');
 var rimraf = require('rimraf');
 var webpack = require('webpack');
+// @ts-ignore
 var webpackVersion = require('webpack/package.json').version;
 var regexEscape = require('escape-string-regexp');
 var typescript = require('typescript');
@@ -44,7 +45,9 @@ if (fs.statSync(testPath).isDirectory() &&
     testToRun !== 'testLib' &&
     !testIsIgnored) {
 
+    // @ts-ignore
     describe(testToRun, function () {
+        // @ts-ignore
         it('should have the correct output', createTest(testToRun, testPath, {}));
 
         if (testToRun === 'declarationOutput' ||
@@ -54,6 +57,7 @@ if (fs.statSync(testPath).isDirectory() &&
             testToRun === 'issue71' ||
             testToRun === 'appendSuffixToWatch') { return; }
 
+        // @ts-ignore
         it('should work with transpile', createTest(testToRun, testPath, { transpile: true }));
     });
 }
@@ -210,7 +214,7 @@ function saveOutputIfRequired(saveOutputMode, paths, outputs, options, patch) {
             }
         });
 
-        fs.copySync(paths.webpackOutput, paths.originalExpectedOutput, { clobber: true });
+        fs.copySync(paths.webpackOutput, paths.originalExpectedOutput, { overwrite: true });
     }
 }
 
@@ -323,7 +327,7 @@ function copyPatchOrEndTest(testStagingPath, watcher, testState, done) {
 
         // can get inconsistent results if copying right away
         setTimeout(function () {
-            fs.copySync(patchPath, testStagingPath, { clobber: true });
+            fs.copySync(patchPath, testStagingPath, { overwrite: true });
         }, 1000);
     }
     else {

test/comparison-tests/jsconfig.json

@@ -1,4 +1,5 @@
 module.exports = function(contents) {
+    // @ts-ignore
     this.cacheable();
     return contents.replace(/\r\n/g, '\n');
 }

test/comparison-tests/newline.loader.js

@@ -7,6 +7,7 @@ var execSync = require('child_process').execSync;
 
 // We only want to run comparison tests for the latest released version
 var typescriptVersion = parseFloat(semver.major(typescript.version) + '.' + semver.minor(typescript.version));
+// @ts-ignore
 if (typescriptVersion < 3.0  || typescriptVersion > 3.0) return;
 
 // Parse command line arguments

test/comparison-tests/run-tests.js

@@ -0,0 +1,16 @@
+{
+    "compilerOptions": {
+        "allowJs": true,
+        "checkJs": true,
+        "module": "commonjs",
+        "noEmit": true,
+        "lib":[
+            "es2015"
+        ]
+    },
+    "files": [
+        "create-and-execute-test.js",
+        "run-tests.js",
+        "newline.loader.js"
+    ]
+}

test/comparison-tests/tsconfig.json

@@ -3,7 +3,7 @@ var fs = require('fs');
 module.exports = function pathExists(path) {
     var pathExists = true;
     try {
-        fs.accessSync(path, fs.F_OK);
+        fs.accessSync(path, fs.constants.F_OK);
     } catch (e) {
         pathExists = false;
     }

test/pathExists.js

@@ -33,9 +33,9 @@
   dependencies:
     "@types/braces" "*"
 
-"@types/node@^9.6.2":
-  version "9.6.20"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-9.6.20.tgz#b59a1bd357ae2df7d44d5ac98e9b64eb96ea1fef"
+"@types/node@^10.0.0":
+  version "10.9.4"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-10.9.4.tgz#0f4cb2dc7c1de6096055357f70179043c33e9897"
 
 "@types/semver@^5.4.0":
   version "5.5.0"
@@ -2836,9 +2836,9 @@ fs-access@^1.0.0:
   dependencies:
     null-check "^1.0.0"
 
-fs-extra@^6.0.0:
-  version "6.0.1"
-  resolved "https://registry.yarnpkg.com/fs-extra/-/fs-extra-6.0.1.tgz#8abc128f7946e310135ddc93b98bddb410e7a34b"
+fs-extra@^7.0.0:
+  version "7.0.0"
+  resolved "https://registry.yarnpkg.com/fs-extra/-/fs-extra-7.0.0.tgz#8cc3f47ce07ef7b3593a11b9fb245f7e34c041d6"
   dependencies:
     graceful-fs "^4.1.2"
     jsonfile "^4.0.0"