Fix missed todo

Author: Gerrit0

src/lib/models/comments/comment.ts

@@ -1,5 +1,5 @@
 import { assertNever, removeIf } from "../../utils";
-import type { Reflection, ReflectionSymbolId } from "../reflections";
+import { Reflection, ReflectionSymbolId } from "../reflections";
 
 import type { Serializer, Deserializer, JSONOutput } from "../../serialization";
 
@@ -233,18 +233,37 @@ export class Comment {
                 case "code":
                     return { ...part };
                 case "inline-tag": {
-                    if (typeof part.target !== "number") {
-                        // TS isn't quite smart enough here...
-                        // GERRIT this is wrong
-                        return { ...part } as CommentDisplayPart;
-                    } else {
+                    if (typeof part.target === "number") {
                         const part2 = {
                             kind: part.kind,
                             tag: part.tag,
                             text: part.text,
-                        };
+                            target: undefined,
+                            tsLinkText: part.tsLinkText,
+                        } satisfies InlineTagDisplayPart;
                         links.push([part.target, part2]);
                         return part2;
+                    } else if (
+                        typeof part.target === "string" ||
+                        part.target === undefined
+                    ) {
+                        return {
+                            kind: "inline-tag",
+                            tag: part.tag,
+                            text: part.text,
+                            target: part.target,
+                            tsLinkText: part.tsLinkText,
+                        } satisfies InlineTagDisplayPart;
+                    } else if (typeof part.target === "object") {
+                        return {
+                            kind: "inline-tag",
+                            tag: part.tag,
+                            text: part.text,
+                            target: new ReflectionSymbolId(part.target),
+                            tsLinkText: part.tsLinkText,
+                        } satisfies InlineTagDisplayPart;
+                    } else {
+                        assertNever(part.target);
                     }
                 }
             }

src/lib/types/ts-internal/index.d.ts

@@ -15,17 +15,6 @@ declare module "typescript" {
         parent?: ts.Symbol;
     }
 
-    interface TypeChecker {
-        // https://github.com/microsoft/TypeScript/blob/v4.1.5/src/compiler/types.ts#L4145
-        // https://github.com/microsoft/TypeScript/issues/42118
-        getTypePredicateOfSignature(
-            signature: ts.Signature
-        ): ts.TypePredicate | undefined;
-
-        // https://github.com/microsoft/TypeScript/blob/v4.7.2/src/compiler/types.ts#L4188
-        getTypeOfSymbol(symbol: Symbol): Type;
-    }
-
     // https://github.com/microsoft/TypeScript/blob/v5.0.2/src/compiler/utilities.ts#L7432
     export function getCheckFlags(symbol: ts.Symbol): CheckFlags;
 

tsconfig.json

@@ -10,7 +10,7 @@
         // Speed up dev compilation time
         "incremental": true,
         "tsBuildInfoFile": "dist/.tsbuildinfo",
-        "skipLibCheck": true,
+        // "skipLibCheck": true,
 
         "experimentalDecorators": true,
         "strict": true,