feat: add parameters as part of the url for fetch

Author: jepser

src/create-client.js

@@ -1,6 +1,7 @@
 /* globals fetch */
 import 'isomorphic-fetch'
 import { API_BASE_URL } from './constants'
+import { buildUrlWithParams } from './utils';
 
 export const clientConstructor = ({ token, ...options }) => {
   return {
@@ -9,9 +10,12 @@ export const clientConstructor = ({ token, ...options }) => {
         url,
         data,
         headers: argsHeaders = {},
+        params,
         ...otherArgs
       } = args
 
+      const requestUrl = buildUrlWithParams(`${API_BASE_URL}${url}`, params)
+
       const {
         headers = {}
       } = options
@@ -21,7 +25,7 @@ export const clientConstructor = ({ token, ...options }) => {
         ...otherArgs
       }
 
-      return fetch(`${API_BASE_URL}${url}`, {
+      return fetch(requestUrl, {
         ...requestParameters,
         body: JSON.stringify(data),
         headers: {

src/utils.js

@@ -19,3 +19,21 @@ export const createMemberPatchQuery = ({ members, operation }) => {
     }
   }))
 }
+
+export const buildUrlWithParams = (url, params = {}) => {
+  const queryParams = Object.keys(params)
+    .reduce((list, key) => {
+      const currentValue = params[key]
+      if (currentValue) {
+        return [
+          ...list,
+          `${encodeURIComponent(key)}=${encodeURIComponent(currentValue)}`
+        ]
+      } else {
+        return list
+      }
+    }, [])
+    .join('&')
+
+  return queryParams ? `${url}?${queryParams}` : url
+}

tests/unit/utils.test.js

@@ -0,0 +1,33 @@
+import { buildUrlWithParams } from '../../src/utils'
+
+test('the url reminds the same if no parameter passed', () => {
+  const url = 'http://typeform.com'
+  expect(buildUrlWithParams(url)).toBe(url)
+})
+
+test('the url has a query string if parameters are passed', () => {
+  const url = 'http://typeform.com'
+  const params = {
+    a: '1',
+    b: '2'
+  }
+  expect(buildUrlWithParams(url, params)).toBe('http://typeform.com?a=1&b=2')
+})
+
+test('parameters should be enconded', () => {
+  const url = 'http://typeform.com'
+  const params = {
+    a: '@1',
+    b: '#2'
+  }
+  expect(buildUrlWithParams(url, params)).toBe('http://typeform.com?a=%401&b=%232')
+})
+
+test.only('undefined values for parameter will be skipped', () => {
+  const url = 'http://typeform.com'
+  const params = {
+    a: '@1',
+    b: undefined
+  }
+  expect(buildUrlWithParams(url, params)).toBe('http://typeform.com?a=%401')
+})