fix(NOJIRA-123): fix Condition variable type property
#52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I retrieve a form from Typeform I notice that some of my condition variables have the value `'choice'` as the type, i.e.
```
{
"op": "is",
"vars": [
{
"type": "field",
"value": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
},
{
"type": "choice",
"value": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" }
]
},
```
The value `'choice'` doesn't appear to be listed in the docs Create API docs:
https://developer.typeform.com/create/reference/create-form/
If i've misunderstood, feel free to close this PR. Otherwise, this PR adds the value `'choice'` to the Condition var `type` property.
mathio
changed the title
type propertytype property
mathio
approved these changes
Oct 4, 2023
|
🎉 This PR is included in version 1.8.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I retrieve a form from Typeform I notice that some of my condition variables have the value
'choice'as the type, i.e.The value
'choice'doesn't appear to be listed in the docs Create API docs:https://developer.typeform.com/create/reference/create-form/
If i've misunderstood, feel free to close this PR. Otherwise, this PR adds the value
'choice'to the Condition vartypeproperty.