throw on buildDirPath and testsDirPath failure

Author: vol0n

clion-plugin/src/main/kotlin/org/utbot/cpp/clion/plugin/settings/UTBotAllProjectSettings.kt

@@ -3,14 +3,15 @@ package org.utbot.cpp.clion.plugin.settings
 import com.intellij.openapi.components.Service
 import com.intellij.openapi.components.service
 import com.intellij.openapi.project.Project
-import com.jetbrains.cidr.cpp.execution.CMakeAppRunConfiguration
+import org.utbot.cpp.clion.plugin.UTBot
+import org.utbot.cpp.clion.plugin.grpc.IllegalPathException
 import org.utbot.cpp.clion.plugin.listeners.UTBotSettingsChangedListener
 import org.utbot.cpp.clion.plugin.ui.targetsToolWindow.UTBotTarget
 import org.utbot.cpp.clion.plugin.utils.convertToRemotePathIfNeeded
 import org.utbot.cpp.clion.plugin.utils.isWindows
-import org.utbot.cpp.clion.plugin.utils.notifyWarning
 import org.utbot.cpp.clion.plugin.utils.path
 import java.io.File
+import java.nio.file.InvalidPathException
 import java.nio.file.Path
 import java.nio.file.Paths
 
@@ -20,10 +21,36 @@ class UTBotAllProjectSettings(val project: Project) {
         get() = project.service<UTBotProjectStoredSettings>().state
 
     val buildDirPath: Path
-        get() = Paths.get(project.path).resolve(storedSettings.buildDirRelativePath)
+        get() {
+            try {
+                return Paths.get(project.path).resolve(storedSettings.buildDirRelativePath)
+            } catch (e: InvalidPathException) {
+                throw IllegalPathException(
+                    UTBot.message(
+                        "paths.invalid",
+                        "relative path to build dir",
+                        storedSettings.buildDirRelativePath
+                    ),
+                    storedSettings.buildDirRelativePath
+                )
+            }
+        }
 
     val testsDirPath: Path
-        get() = Paths.get(project.path).resolve(storedSettings.testsDirRelativePath)
+        get() {
+            try {
+                return Paths.get(project.path).resolve(storedSettings.testsDirRelativePath)
+            } catch (e: InvalidPathException) {
+                throw IllegalPathException(
+                    storedSettings.testsDirRelativePath,
+                    UTBot.message(
+                        "paths.invalid",
+                        "relative path to tests dir",
+                        storedSettings.testsDirRelativePath
+                    )
+                )
+            }
+        }
 
     val convertedSourcePaths: List<String>
         get() = storedSettings.sourceDirs.map { it.convertToRemotePathIfNeeded(project) }
@@ -52,7 +79,7 @@ class UTBotAllProjectSettings(val project: Project) {
 
     fun fireUTBotSettingsChanged() {
         project.messageBus.let { bus ->
-            if(!bus.isDisposed)
+            if (!bus.isDisposed)
                 bus.syncPublisher(UTBotSettingsChangedListener.TOPIC).settingsChanged(this)
         }
     }

clion-plugin/src/main/kotlin/org/utbot/cpp/clion/plugin/ui/testsResults/UTBotTestRunLineMarkerProvider.kt

@@ -11,9 +11,11 @@ import com.intellij.psi.PsiElement
 import javax.swing.Icon
 import kotlin.io.path.name
 import org.utbot.cpp.clion.plugin.actions.generate.RunWithCoverageAction
+import org.utbot.cpp.clion.plugin.grpc.IllegalPathException
 import org.utbot.cpp.clion.plugin.settings.settings
 import org.utbot.cpp.clion.plugin.ui.services.TestsResultsStorage
 import org.utbot.cpp.clion.plugin.utils.localPath
+import org.utbot.cpp.clion.plugin.utils.logger
 import testsgen.Testgen
 
 class UTBotTestRunLineMarkerProvider : LineMarkerProvider {
@@ -57,10 +59,15 @@ class UTBotTestRunLineMarkerProvider : LineMarkerProvider {
 
             private fun isElementInTestFileGeneratedByUTBot(element: PsiElement) =
                 element.containingFile.virtualFile.localPath.let {
-                    it.toString().startsWith(element.project.settings.testsDirPath.toString()) &&
-                            it.name.contains("test")
+                    try {
+                        it.toString().startsWith(element.project.settings.testsDirPath.toString()) &&
+                                it.name.contains("test")
+                    } catch (e: IllegalPathException) {
+                        return false
+                    }
                 }
 
+
             fun getStatusIcon(element: PsiElement): Icon {
                 // return icon for Running All Tests
                 if (element.canPlaceAllTestsIcon()) {

clion-plugin/src/main/kotlin/org/utbot/cpp/clion/plugin/utils/UiUtils.kt

@@ -10,7 +10,6 @@ import com.intellij.ui.DocumentAdapter
 import com.intellij.ui.RawCommandLineEditor
 import com.intellij.ui.dsl.builder.Row
 import com.intellij.ui.layout.PropertyBinding
-import javax.swing.JSpinner
 import javax.swing.JTextField
 import javax.swing.event.DocumentEvent
 

clion-plugin/src/main/resources/messages/UTBot.properties

@@ -61,6 +61,8 @@ folderPath.wrong.conversion=Could not create relative path from remote path to f
 filePath.wrong.conversion=Could not create relative path from remote path to file path! Review your remote path in settings \
     and make sure file you generate tests for is under project root.
 # hardly it will ever happen
+#0 - path name (e.g relative path to ...), #1 - path value
+paths.invalid=Invalid {0}: {1}. Please review it in settings!
 projectPath.wrong.conversion=Could not convert project path to remote version. Please, report this issue, <a href=https://github.com/UnitTestBot/UTBotCpp/issues>here</a>
 testFilePath.wrong.conversion=Could not create relative path from remote path to test file! Please review your remote path in settings \
     and make sure test file is under project root.