Fix wizard bugs (#566)

* Add opportunity to skip plugins install page

* Add opportunity to install own username/password from sftp.json

* Add warning messages after start page if SFTP and SARIF are not installed.

Author: kichunya

vscode-plugin/media/wizardHTML.js

@@ -302,10 +302,18 @@ function defaultValidateForEmptyValue() {
 function validateForm() {
     let valid = true;
     if (isStartTab()) {
-        // call them all - we need to mark all invalid input
-        valid &= isPluginInstalledAndMarkValid("SFTP_")
-        valid &= isPluginInstalledAndMarkValid("SARIF_");
-    } else if (isConnectionTab()) {
+        if (!isPluginInstalledAndMarkValid("SFTP_")){
+            vscode.postMessage({
+                command: 'check_sftp_on_start'
+            });;
+        }
+        if(!isPluginInstalledAndMarkValid("SARIF_")){
+            vscode.postMessage({
+                command: 'check_sarif_on_start'
+            });;
+        }
+    }
+    if (isConnectionTab()) {
         // call them all - we need to mark all invalid input
         valid &= isConnectionPortValid($("portGRPCInput"), GRPC_PREFIX);
         valid &= isConnectionPortValid($("portSFTPInput"), SFTP_PREFIX);

vscode-plugin/src/config/defaultValues.ts

@@ -52,6 +52,22 @@ export class DefaultConfigValues {
         return DefaultConfigValues.DEFAULT_SFTP_PORT;
     }
 
+    public static getDefaultSFTPUsername(): string{
+        const username = vsUtils.getFromSftpConfig("username");
+        if ((username === undefined) || (username.length === 0)) {
+            return "utbot";
+        }
+        return username.toString();
+    }
+
+    public static getDefaultSFTPPassword(): string{
+        const password = vsUtils.getFromSftpConfig("password");
+        if ((password === undefined) || (password.length === 0)) {
+            return "utbot";
+        }
+        return password.toString();
+    }
+
     public static getDefaultRemotePath(): string {
         let remotePath = Prefs.getRemotePath();
         if (remotePath.length === 0) {

vscode-plugin/src/wizard/wizard.ts

@@ -85,6 +85,12 @@ export class UtbotWizardPanel {
                         //logger.info(`check_plugins`);
                         this.checkPlugins();
                         break;
+                    case 'check_sftp_on_start':
+                        this.checkSFTPOnStart();
+                        break;
+                    case 'check_sarif_on_start':
+                        this.checkSARIFOnStart();
+                        break;
                     default: {
                         if (message.command.endsWith('test_connection')) {
                             //messages.showErrorMessage(`!!!!!! message (${message.command}) from WizardWebView: ${message}`);
@@ -122,6 +128,13 @@ export class UtbotWizardPanel {
             sarifPluginInstalled: !!vs.extensions.getExtension(messages.defaultSARIFViewer)
         });
     }
+    private checkSFTPOnStart(): void  {
+        messages.showWarningMessage(messages.installSFTP);
+    }
+
+    private checkSARIFOnStart(): void  {
+        messages.showWarningMessage(messages.installSARIFViewer);
+    }
 
     private static GENERATED = "This file is automatically generated by UnitTestBot.";
     private async setupSFTP(
@@ -258,11 +271,13 @@ export class UtbotWizardPanel {
     private lastSFTPRequest: Promise<any> | null = null;
     private pingSFTPAction(host: string, port: number, successCmd: string, failureCmd: string): void {
         const ssh = new NodeSSH();
+        const username = defcfg.DefaultConfigValues.getDefaultSFTPUsername().toString();
+        const password = defcfg.DefaultConfigValues.getDefaultSFTPPassword().toString();
         const capturedPingPromiseForLambda = ssh.connect({
             host: host,
             port: port,
-            username: 'utbot',
-            password: 'utbot'
+            username: username,
+            password: password
         });
         this.lastSFTPRequest = capturedPingPromiseForLambda;
         capturedPingPromiseForLambda.then( async () => {