Skip to content

Fixing generations for files that included in two targets #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Aug 25, 2022
Merged

Fixing generations for files that included in two targets #258

merged 27 commits into from
Aug 25, 2022

Conversation

ladisgin
Copy link
Member

@ladisgin ladisgin commented Jun 2, 2022 •
edited
Loading

Fixed

  • Not generate tests for files that include in two targets
  • Project generation request not generate files into subdirectory

This was linked to issues Jun 2, 2022
Files are skipped by mistake in project request (invalid targets command search) #223
Closed
UTBotCpp creates empty test files for files that are not presented in compile/link commands for chosen target #155
Closed
operasfantom
operasfantom reviewed Jun 2, 2022
View reviewed changes
Copy link
Collaborator

@operasfantom operasfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be close attention to the main comment and be able to ignore others

@ladisgin ladisgin force-pushed the ladisgin/fix_skipping_file_in_target branch from 1656423 to 731e3f1 Compare June 3, 2022 09:40
@ladisgin ladisgin marked this pull request as draft June 8, 2022 13:29
@ladisgin ladisgin force-pushed the ladisgin/fix_skipping_file_in_target branch from 731e3f1 to de94ec6 Compare June 17, 2022 08:44
@ladisgin ladisgin removed a link to an issue Jun 17, 2022
UTBotCpp creates empty test files for files that are not presented in compile/link commands for chosen target #155
Closed
@ladisgin ladisgin force-pushed the ladisgin/fix_skipping_file_in_target branch 2 times, most recently from 8110b8f to 9f22d00 Compare June 20, 2022 13:51
@ladisgin ladisgin force-pushed the ladisgin/fix_skipping_file_in_target branch 3 times, most recently from 96aaf90 to 5d659e6 Compare July 5, 2022 10:48
@ladisgin ladisgin force-pushed the ladisgin/fix_skipping_file_in_target branch 5 times, most recently from 59693a6 to 9ec97f5 Compare July 19, 2022 14:38
@ladisgin ladisgin force-pushed the ladisgin/fix_skipping_file_in_target branch 2 times, most recently from 58c888d to 4b7ace3 Compare July 28, 2022 15:34
@ladisgin ladisgin force-pushed the ladisgin/fix_skipping_file_in_target branch 3 times, most recently from 0680734 to c21e0d6 Compare August 9, 2022 10:50
@ladisgin ladisgin marked this pull request as ready for review August 10, 2022 14:28
operasfantom
operasfantom requested changes Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@operasfantom operasfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There really something to be done before merging, for the most part, object-oriented issues

@ladisgin ladisgin force-pushed the ladisgin/fix_skipping_file_in_target branch from 6ab6c8d to b9fb42b Compare August 16, 2022 17:27
@ladisgin ladisgin force-pushed the ladisgin/fix_skipping_file_in_target branch from a63f708 to 840cdd9 Compare August 25, 2022 07:02
@ladisgin ladisgin merged commit 32c0298 into main Aug 25, 2022
@ladisgin ladisgin deleted the ladisgin/fix_skipping_file_in_target branch August 30, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-utkin alexey-utkin alexey-utkin approved these changes

@operasfantom operasfantom operasfantom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Files are skipped by mistake in project request (invalid targets command search)
3 participants
@ladisgin @alexey-utkin @operasfantom