Skip to content

Commit 5005840

Browse files
committed
changed AssetDatabase.SaveAssets() to AssetDatabase.Refresh()
1 parent b7a4c06 commit 5005840

File tree

8 files changed

+24
-10
lines changed

8 files changed

+24
-10
lines changed

source/FrameRecorder/Core/Editor/RTInputSelector.cs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,14 @@ namespace UnityEditor.FrameRecorder
77
{
88
public class RTInputSelector
99
{
10-
public string title { get; set; }
10+
string title { get; set; }
11+
bool enforceEvenSize { get; set; }
1112
string[] candidates = { "Camera output", "Offscreen rendering", "Render Texture" };
1213

13-
public RTInputSelector(string title)
14+
public RTInputSelector(string title, bool enforceEvenSize )
1415
{
1516
this.title = title;
17+
this.enforceEvenSize = enforceEvenSize;
1618
}
1719

1820
public bool OnInputGui( ref RecorderInputSetting input)
@@ -39,6 +41,12 @@ public bool OnInputGui( ref RecorderInputSetting input)
3941
var newSettings = ScriptableObject.CreateInstance(newType) as RecorderInputSetting;
4042
newSettings.m_DisplayName = title;
4143
input = newSettings;
44+
45+
if (newSettings is CBRenderTextureInputSettings)
46+
(newSettings as CBRenderTextureInputSettings).m_PadSize = enforceEvenSize;
47+
if (newSettings is AdamBeautyInputSettings)
48+
(newSettings as AdamBeautyInputSettings).m_ForceEvenSize = enforceEvenSize;
49+
4250
return true;
4351
}
4452

source/FrameRecorder/Core/Editor/RecorderEditor.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ protected void AddSourceSettings(RecorderInputSetting sourceSettings)
135135
sourceSettings.name = GUID.Generate().ToString();
136136

137137
AssetDatabase.AddObjectToAsset(sourceSettings, serializedObject.targetObject);
138-
AssetDatabase.SaveAssets();
138+
AssetDatabase.Refresh();
139139

140140
m_Inputs.InsertArrayElementAtIndex(m_Inputs.arraySize);
141141
var arryItem = m_Inputs.GetArrayElementAtIndex(m_Inputs.arraySize-1);
@@ -153,7 +153,7 @@ public void ChangeInputSettings(int atIndex, RecorderInputSetting newSettings)
153153
newSettings.name = GUID.Generate().ToString();
154154

155155
AssetDatabase.AddObjectToAsset(newSettings, serializedObject.targetObject);
156-
AssetDatabase.SaveAssets();
156+
AssetDatabase.Refresh();
157157

158158
var arryItem = m_Inputs.GetArrayElementAtIndex(atIndex);
159159
UnityHelpers.Destroy(arryItem.objectReferenceValue, true);

source/FrameRecorder/Core/Editor/RecorderWindow.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public void OnGUI()
7878
{
7979
m_WindowSettingsAsset = ScriptableObject.CreateInstance<RecorderWindowSettings>();
8080
AssetDatabase.CreateAsset(m_WindowSettingsAsset, "Assets/FrameRecordingSettings.asset");
81-
AssetDatabase.SaveAssets();
81+
AssetDatabase.Refresh();
8282
}
8383
}
8484

@@ -291,7 +291,7 @@ public void OnRecorderSelected()
291291
if( m_WindowSettingsAsset.m_Settings == null )
292292
m_WindowSettingsAsset.m_Settings = RecordersInventory.GenerateNewSettingsAsset(m_WindowSettingsAsset, m_recorderSelector.selectedRecorder );
293293
m_Editor = Editor.CreateEditor( m_WindowSettingsAsset.m_Settings ) as RecorderEditor;
294-
AssetDatabase.SaveAssets();
294+
AssetDatabase.Refresh();
295295

296296
}
297297

source/FrameRecorder/Core/Editor/Timeline/RecorderClipEditor.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public void OnRecorderSelected()
8181
if(clip.m_Settings == null)
8282
clip.m_Settings = RecordersInventory.GenerateNewSettingsAsset(clip, m_recorderSelector.selectedRecorder );
8383
m_Editor = Editor.CreateEditor(clip.m_Settings) as RecorderEditor;
84-
AssetDatabase.SaveAssets();
84+
AssetDatabase.Refresh();
8585
}
8686

8787
TimelineAsset FindTimelineAsset()

source/FrameRecorder/Core/Engine/RecordersInventory.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ public static RecorderSettings GenerateNewSettingsAsset(UnityEngine.Object paren
188188
settings.recorderType = recorderType;
189189

190190
AssetDatabase.AddObjectToAsset(settings, parentAsset);
191-
AssetDatabase.SaveAssets();
191+
AssetDatabase.Refresh();
192192
return settings;
193193
}
194194
else

source/FrameRecorder/Inputs/Adam/Engine/AdamBeautyInput.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,12 @@ public override void BeginRecording(RecordingSession session)
112112
m_renderHeight = (int)adamSettings.m_RenderSize;
113113
m_renderWidth = Mathf.Min(16 * 1024, Mathf.RoundToInt(m_renderHeight * aspect));
114114
m_outputHeight = (int)adamSettings.m_FinalSize;
115-
m_outputWidth = Mathf.Min(16 * 1024, Mathf.RoundToInt(m_outputHeight * aspect)) & ~1;
115+
m_outputWidth = Mathf.Min(16 * 1024, Mathf.RoundToInt(m_outputHeight * aspect));
116+
if (adamSettings.m_ForceEvenSize)
117+
{
118+
m_outputWidth &= ~1;
119+
m_outputHeight &= ~1;
120+
}
116121

117122
m_superMaterial = new Material(superShader);
118123
m_superMaterial.hideFlags = HideFlags.DontSave;

source/FrameRecorder/Inputs/Adam/Engine/AdamBeautyInputSettings.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ public class AdamBeautyInputSettings : InputSettings<AdamBeautyInput>
1111
public float m_SuperKernelScale = 1f;
1212
public RenderTexture m_RenderTexture;
1313
public string m_CameraTag;
14+
public bool m_ForceEvenSize = false;
1415

1516
public AdamBeautyInputSettings()
1617
{

source/FrameRecorder/Recorders/ImageRecorder/Editor/ImageRecorderEditor.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ protected override void OnEnable()
2424
if (target == null)
2525
return;
2626

27-
m_RTInputSelector = new RTInputSelector("Pixels");
27+
m_RTInputSelector = new RTInputSelector("Pixels", false);
2828

2929
var pf = new PropertyFinder<ImageRecorderSettings>(serializedObject);
3030
m_Inputs = pf.Find(w => w.m_SourceSettings);

0 commit comments

Comments
 (0)