Skip to content

Commit 8b9cfe3

Browse files
committed
removed dead code and changed some default settings
default's to CB based capturing and Manual resolution
1 parent 7119aec commit 8b9cfe3

File tree

5 files changed

+2
-23
lines changed

5 files changed

+2
-23
lines changed

source/Core/FrameRecorder/Core/Engine/Recorder.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ public abstract class Recorder : ScriptableObject
2121
{
2222
double m_OriginalCaptureFrameRate;
2323

24-
public abstract List<RecorderInputSetting> DefaultInputs();
25-
2624
public int recordedFramesCount { get; set; }
2725

2826
protected List<RecorderInput> m_Inputs;

source/Core/FrameRecorder/Core/Engine/RecordersInventory.cs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -193,14 +193,5 @@ public static RecorderSettings GenerateNewSettingsAsset(UnityEngine.Object paren
193193
else
194194
throw new ArgumentException("No factory was registered for " + recorderType.Name);
195195
}
196-
197-
public static List<RecorderInputSetting> GetRecordersDefaultSourceSettings(Type recorderType)
198-
{
199-
var recorder = ScriptableObject.CreateInstance(recorderType) as Recorder;
200-
var defautSettings = recorder.DefaultInputs();
201-
UnityHelpers.Destroy(recorder);
202-
return defautSettings;
203-
}
204-
205196
}
206197
}

source/Core/FrameRecorder/Inputs/CBRenderTexture/Engine/CBRenderTextureInputSettings.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
public class CBRenderTextureInputSettings : InputSettings<CBRenderTextureInput>
44
{
55
public EImageSource source = EImageSource.GameDisplay;
6-
public EImageDimension m_RenderSize = EImageDimension.x720p_HD;
6+
public EImageDimension m_RenderSize = EImageDimension.Manual;
77
public string m_CameraTag;
88
public RenderTexture m_SourceRTxtr;
99
public bool m_FlipVertical = false;

source/Core/FrameRecorder/Recorders/PNG/Engine/PNGRecorder.cs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -56,15 +56,5 @@ public override void RecordFrame(RecordingSession session)
5656

5757
File.WriteAllBytes(MakeFileName(session), bytes);
5858
}
59-
60-
public override List<RecorderInputSetting> DefaultInputs()
61-
{
62-
var settings = new List<RecorderInputSetting>();
63-
var setting = ScriptableObject.CreateInstance(typeof(AdamBeautyInputSettings)) as AdamBeautyInputSettings;
64-
65-
settings.Add(setting);
66-
return settings;
67-
}
68-
6959
}
7060
}

source/Core/FrameRecorder/Recorders/PNG/Engine/PNGRecorderSettings.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public class PNGRecorderSettings : RecorderSettings
2020

2121
public override List<RecorderInputSetting> GetDefaultSourcesSettings()
2222
{
23-
return new List<RecorderInputSetting>() { ScriptableObject.CreateInstance<AdamBeautyInputSettings>() };
23+
return new List<RecorderInputSetting>() { ScriptableObject.CreateInstance<CBRenderTextureInputSettings>() };
2424
}
2525

2626
public override bool isValid

0 commit comments

Comments
 (0)