vbnv

Author: jasonm-unity

source/FrameRecorder/Core/Engine/RecordingSession.cs

@@ -46,12 +46,25 @@ public void RecordFrame()
             m_Recorder.SignalSourcesOfStage(ERecordingSessionStage.FrameDone, this);
 
             // Note: This is not great when multiple recorders are simultaneously active...
-            if (m_Recorder.settings.m_FrameRateMode == FrameRateMode.Constant && m_Recorder.settings.m_SynchFrameRate )
+            if (m_Recorder.settings.m_FrameRateMode == FrameRateMode.Variable ||
+                (m_Recorder.settings.m_FrameRateMode == FrameRateMode.Constant && m_Recorder.settings.m_SynchFrameRate)
+            )
             {
-                float target =(float) (1.0f / m_Recorder.settings.m_FrameRate) * (Time.renderedFrameCount - m_InitialFrame);
-                double sleep = (target - (Time.unscaledTime - m_RecordingStartTS)) * 1000;
+                var frameCount = Time.renderedFrameCount - m_InitialFrame;
+                var frameLen = 1.0f / m_Recorder.settings.m_FrameRate;
+                var elapsed = Time.unscaledTime - m_RecordingStartTS;
+                var target = frameLen * (frameCount+1);
+                var sleep =  (int)((target - elapsed) * 1000);
+
                 if (sleep > 0)
-                    System.Threading.Thread.Sleep((int)sleep);
+                {
+                    if(settings.m_Verbose)
+                        Debug.Log( string.Format("Recording session info => dT: {0:F1}s, Target dT: {1:F1}s, Retarding: {2}ms, fps: {3:F1}", elapsed, target, sleep, frameCount / elapsed ));
+
+                    System.Threading.Thread.Sleep(sleep);
+                }
+                else if (sleep < -frameLen)
+                    m_InitialFrame--;
             }
         }
 

source/FrameRecorder/Recorders/ImageRecorder/Editor/ImageRecorderEditor.cs

@@ -27,7 +27,7 @@ protected override void OnEnable()
             if (target == null)
                 return;
 
-            m_Candidates = new [] { "Command Buffered Camera", "Camera as RenderTexture", "Render Texture" };
+            m_Candidates = new [] { "Command Buffered Camera", "Offscreen rendering", "Render Texture" };
             var pf = new PropertyFinder<ImageRecorderSettings>(serializedObject);
             m_Inputs = pf.Find(w => w.m_SourceSettings);
             m_DestinationPath = pf.Find(w => w.m_DestinationPath);

source/FrameRecorder/Recorders/ImageRecorder/Engine/ImageRecorder.cs

@@ -33,8 +33,6 @@ public override void RecordFrame(RecordingSession session)
             tex.ReadPixels(new Rect(0, 0, width, height), 0, 0);
             tex.Apply();
             RenderTexture.active = backupActive;
-            
-            //var tex = ScreenCapture.CaptureScreenshotAsTexture();
 
             byte[] bytes;
             switch (m_Settings.m_OutputFormat)