Skip to content

Fixed typo in github link #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Fixed typo in github link #765

merged 1 commit into from
Sep 8, 2022

Conversation

Grave18
Copy link
Contributor

@Grave18 Grave18 commented Sep 3, 2022

Select the type of change:

  • Small Changes - Typos, formatting, slight revisions
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - Updates, maintenance, and new packages for the site and Docusaurus

Purpose of the Pull Request:
https://github.com/Unity-Technologies/com.unity.multiplayer.samples.coop/blob/main/Assets/Scripts/Gameplay/ConnectionManagement/ServerGameNetPortal.css#L176 .css is a typo

Issue Number:
#728 - closed but issue isn't solved
#767 - new issue

@unity-cla-assistant
Copy link

unity-cla-assistant commented Sep 3, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@chrispope chrispope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Grave18 Grave18 marked this pull request as draft September 6, 2022 13:12
@Grave18 Grave18 marked this pull request as ready for review September 6, 2022 13:12
@s-omeilia-unity s-omeilia-unity merged commit 9cdefbc into Unity-Technologies:main Sep 8, 2022
armstrongl pushed a commit that referenced this pull request Oct 3, 2022
* Fixed typo in github link (#765)

https://github.com/Unity-Technologies/com.unity.multiplayer.samples.coop/blob/main/Assets/Scripts/Gameplay/ConnectionManagement/ServerGameNetPortal.css#L176 => https://github.com/Unity-Technologies/com.unity.multiplayer.samples.coop/blob/main/Assets/Scripts/Gameplay/ConnectionManagement/ServerGameNetPortal.cs#L176

* update changelog for NGO 1.0.1 and 1.0.2

* MTT-4369 Update UTP documentation to 2.0 documentation structure

* Update version-2.0.0-sidebars.json

* Removed .bak files

* Update NGO 1.0.1 changelog

Co-authored-by: Grave <[email protected]>
Co-authored-by: Johann Ruwet <[email protected]>
armstrongl pushed a commit that referenced this pull request Oct 4, 2022
* Fixed typo in github link (#765)

https://github.com/Unity-Technologies/com.unity.multiplayer.samples.coop/blob/main/Assets/Scripts/Gameplay/ConnectionManagement/ServerGameNetPortal.css#L176 => https://github.com/Unity-Technologies/com.unity.multiplayer.samples.coop/blob/main/Assets/Scripts/Gameplay/ConnectionManagement/ServerGameNetPortal.cs#L176

* update changelog for NGO 1.0.1 and 1.0.2

* MTT-4369 Update UTP documentation to 2.0 documentation structure

* Update version-2.0.0-sidebars.json

* Removed .bak files

* Update NGO 1.0.1 changelog

Co-authored-by: Grave <[email protected]>
Co-authored-by: Johann Ruwet <[email protected]>
chrispope added a commit that referenced this pull request Oct 4, 2022
* delete event loop file on main (#798)

* delete event loop file on main

delete event loop file on main, retaining on develop

* Update TP v sidebars.js

Update TP v sidebars.js removing from TOC

* Update version-2.0.0-sidebars.json

Co-authored-by: Brian Coughlin <[email protected]>

* Update NGO changelog for 1.0.1 and 1.0.2 (#774)

* Fixed typo in github link (#765)

https://github.com/Unity-Technologies/com.unity.multiplayer.samples.coop/blob/main/Assets/Scripts/Gameplay/ConnectionManagement/ServerGameNetPortal.css#L176 => https://github.com/Unity-Technologies/com.unity.multiplayer.samples.coop/blob/main/Assets/Scripts/Gameplay/ConnectionManagement/ServerGameNetPortal.cs#L176

* update changelog for NGO 1.0.1 and 1.0.2

* MTT-4369 Update UTP documentation to 2.0 documentation structure

* Update version-2.0.0-sidebars.json

* Removed .bak files

* Update NGO 1.0.1 changelog

Co-authored-by: Grave <[email protected]>
Co-authored-by: Johann Ruwet <[email protected]>

* delete event loop file from TP v2.0 docs (#799)

* delete event loop file from TP v2.0 docs

delete event loop file from TP v2.0 docs

* Removing event loop from sidebars

Removing event loop from sidebars

* Add changelog for UTP 1.3.0 (#801)

* fix broken link to client driven sample (#804)

* delete event loop file on main (#798)

* delete event loop file on main

delete event loop file on main, retaining on develop

* Update TP v sidebars.js

Update TP v sidebars.js removing from TOC

* Update version-2.0.0-sidebars.json

Co-authored-by: Brian Coughlin <[email protected]>

* Fix broken link to client-driven sample

Fix broken link to client-driven sample

Co-authored-by: Brian Coughlin <[email protected]>
Co-authored-by: Larah Armstrong <[email protected]>

* Fix sidebar

Co-authored-by: Christopher Pope <[email protected]>
Co-authored-by: Brian Coughlin <[email protected]>
Co-authored-by: Grave <[email protected]>
Co-authored-by: Johann Ruwet <[email protected]>
chrispope added a commit that referenced this pull request Oct 4, 2022
* delete event loop file from TP v2.0 docs (#799)

* delete event loop file from TP v2.0 docs

delete event loop file from TP v2.0 docs

* Removing event loop from sidebars

Removing event loop from sidebars

* Update NGO changelog for 1.0.1 and 1.0.2 (#774)

* Fixed typo in github link (#765)

https://github.com/Unity-Technologies/com.unity.multiplayer.samples.coop/blob/main/Assets/Scripts/Gameplay/ConnectionManagement/ServerGameNetPortal.css#L176 => https://github.com/Unity-Technologies/com.unity.multiplayer.samples.coop/blob/main/Assets/Scripts/Gameplay/ConnectionManagement/ServerGameNetPortal.cs#L176

* update changelog for NGO 1.0.1 and 1.0.2

* MTT-4369 Update UTP documentation to 2.0 documentation structure

* Update version-2.0.0-sidebars.json

* Removed .bak files

* Update NGO 1.0.1 changelog

Co-authored-by: Grave <[email protected]>
Co-authored-by: Johann Ruwet <[email protected]>

* Add changelog for UTP 1.3.0 (#801)

* fix broken link to client driven sample (#804)

* delete event loop file on main (#798)

* delete event loop file on main

delete event loop file on main, retaining on develop

* Update TP v sidebars.js

Update TP v sidebars.js removing from TOC

* Update version-2.0.0-sidebars.json

Co-authored-by: Brian Coughlin <[email protected]>

* Fix broken link to client-driven sample

Fix broken link to client-driven sample

Co-authored-by: Brian Coughlin <[email protected]>
Co-authored-by: Larah Armstrong <[email protected]>

* Sync sidebar (#808)

* delete event loop file on main (#798)

* delete event loop file on main

delete event loop file on main, retaining on develop

* Update TP v sidebars.js

Update TP v sidebars.js removing from TOC

* Update version-2.0.0-sidebars.json

Co-authored-by: Brian Coughlin <[email protected]>

* Update NGO changelog for 1.0.1 and 1.0.2 (#774)

* Fixed typo in github link (#765)

https://github.com/Unity-Technologies/com.unity.multiplayer.samples.coop/blob/main/Assets/Scripts/Gameplay/ConnectionManagement/ServerGameNetPortal.css#L176 => https://github.com/Unity-Technologies/com.unity.multiplayer.samples.coop/blob/main/Assets/Scripts/Gameplay/ConnectionManagement/ServerGameNetPortal.cs#L176

* update changelog for NGO 1.0.1 and 1.0.2

* MTT-4369 Update UTP documentation to 2.0 documentation structure

* Update version-2.0.0-sidebars.json

* Removed .bak files

* Update NGO 1.0.1 changelog

Co-authored-by: Grave <[email protected]>
Co-authored-by: Johann Ruwet <[email protected]>

* delete event loop file from TP v2.0 docs (#799)

* delete event loop file from TP v2.0 docs

delete event loop file from TP v2.0 docs

* Removing event loop from sidebars

Removing event loop from sidebars

* Add changelog for UTP 1.3.0 (#801)

* fix broken link to client driven sample (#804)

* delete event loop file on main (#798)

* delete event loop file on main

delete event loop file on main, retaining on develop

* Update TP v sidebars.js

Update TP v sidebars.js removing from TOC

* Update version-2.0.0-sidebars.json

Co-authored-by: Brian Coughlin <[email protected]>

* Fix broken link to client-driven sample

Fix broken link to client-driven sample

Co-authored-by: Brian Coughlin <[email protected]>
Co-authored-by: Larah Armstrong <[email protected]>

* Fix sidebar

Co-authored-by: Christopher Pope <[email protected]>
Co-authored-by: Brian Coughlin <[email protected]>
Co-authored-by: Grave <[email protected]>
Co-authored-by: Johann Ruwet <[email protected]>

Co-authored-by: Christopher Pope <[email protected]>
Co-authored-by: Grave <[email protected]>
Co-authored-by: Johann Ruwet <[email protected]>
Co-authored-by: Brian Coughlin <[email protected]>
chrispope added a commit that referenced this pull request Oct 5, 2022
* delete event loop file from TP v2.0 docs (#799)

* delete event loop file from TP v2.0 docs

delete event loop file from TP v2.0 docs

* Removing event loop from sidebars

Removing event loop from sidebars

* Update NGO changelog for 1.0.1 and 1.0.2 (#774)

* Fixed typo in github link (#765)

https://github.com/Unity-Technologies/com.unity.multiplayer.samples.coop/blob/main/Assets/Scripts/Gameplay/ConnectionManagement/ServerGameNetPortal.css#L176 => https://github.com/Unity-Technologies/com.unity.multiplayer.samples.coop/blob/main/Assets/Scripts/Gameplay/ConnectionManagement/ServerGameNetPortal.cs#L176

* update changelog for NGO 1.0.1 and 1.0.2

* MTT-4369 Update UTP documentation to 2.0 documentation structure

* Update version-2.0.0-sidebars.json

* Removed .bak files

* Update NGO 1.0.1 changelog

Co-authored-by: Grave <[email protected]>
Co-authored-by: Johann Ruwet <[email protected]>

* Add changelog for UTP 1.3.0 (#801)

* fix broken link to client driven sample (#804)

* delete event loop file on main (#798)

* delete event loop file on main

delete event loop file on main, retaining on develop

* Update TP v sidebars.js

Update TP v sidebars.js removing from TOC

* Update version-2.0.0-sidebars.json

Co-authored-by: Brian Coughlin <[email protected]>

* Fix broken link to client-driven sample

Fix broken link to client-driven sample

Co-authored-by: Brian Coughlin <[email protected]>
Co-authored-by: Larah Armstrong <[email protected]>

* Sync sidebar (#808)

* delete event loop file on main (#798)

* delete event loop file on main

delete event loop file on main, retaining on develop

* Update TP v sidebars.js

Update TP v sidebars.js removing from TOC

* Update version-2.0.0-sidebars.json

Co-authored-by: Brian Coughlin <[email protected]>

* Update NGO changelog for 1.0.1 and 1.0.2 (#774)

* Fixed typo in github link (#765)

https://github.com/Unity-Technologies/com.unity.multiplayer.samples.coop/blob/main/Assets/Scripts/Gameplay/ConnectionManagement/ServerGameNetPortal.css#L176 => https://github.com/Unity-Technologies/com.unity.multiplayer.samples.coop/blob/main/Assets/Scripts/Gameplay/ConnectionManagement/ServerGameNetPortal.cs#L176

* update changelog for NGO 1.0.1 and 1.0.2

* MTT-4369 Update UTP documentation to 2.0 documentation structure

* Update version-2.0.0-sidebars.json

* Removed .bak files

* Update NGO 1.0.1 changelog

Co-authored-by: Grave <[email protected]>
Co-authored-by: Johann Ruwet <[email protected]>

* delete event loop file from TP v2.0 docs (#799)

* delete event loop file from TP v2.0 docs

delete event loop file from TP v2.0 docs

* Removing event loop from sidebars

Removing event loop from sidebars

* Add changelog for UTP 1.3.0 (#801)

* fix broken link to client driven sample (#804)

* delete event loop file on main (#798)

* delete event loop file on main

delete event loop file on main, retaining on develop

* Update TP v sidebars.js

Update TP v sidebars.js removing from TOC

* Update version-2.0.0-sidebars.json

Co-authored-by: Brian Coughlin <[email protected]>

* Fix broken link to client-driven sample

Fix broken link to client-driven sample

Co-authored-by: Brian Coughlin <[email protected]>
Co-authored-by: Larah Armstrong <[email protected]>

* Fix sidebar

Co-authored-by: Christopher Pope <[email protected]>
Co-authored-by: Brian Coughlin <[email protected]>
Co-authored-by: Grave <[email protected]>
Co-authored-by: Johann Ruwet <[email protected]>

* MTT-4370: UTP 2.0 migration guide (#752)

* Preliminary version of the UTP 2.0 migration guide

* Address review comments

* Mention breaking change in INetworkInterface.Initialize

* Add sections on editor support and collections update

* Preliminary version of the UTP 2.0 migration guide

* Address review comments

* Mention breaking change in INetworkInterface.Initialize

* Add sections on editor support and collections update

* Minor adjustments to the UTP 2.0 migration guide

* Minor fixes

Co-authored-by: Larah Armstrong <[email protected]>
Co-authored-by: Larah Armstrong <[email protected]>

Co-authored-by: Larah Armstrong <[email protected]>
Co-authored-by: Grave <[email protected]>
Co-authored-by: Johann Ruwet <[email protected]>
Co-authored-by: Brian Coughlin <[email protected]>
Co-authored-by: Simon Lemay <[email protected]>
Co-authored-by: Larah Armstrong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants