extracted duplicated methods to NetworkOverlay

Author: LPLafontaineB

Assets/BossRoom/Scripts/Infrastructure/Editor/NetworkLatencyWarning.cs

@@ -67,19 +67,7 @@ void CreateLatencyText()
             Assert.IsNotNull(NetworkOverlay.Instance,
                 "No NetworkOverlay object part of scene. Add NetworkOverlay prefab to bootstrap scene!");
 
-            var statUI = new GameObject("UI Latency Warning Text");
-
-            m_LatencyText = statUI.AddComponent<TextMeshProUGUI>();
-            m_LatencyText.fontSize = 32;
-            m_LatencyText.horizontalAlignment = HorizontalAlignmentOptions.Left;
-            m_LatencyText.verticalAlignment = VerticalAlignmentOptions.Middle;
-            m_LatencyText.raycastTarget = false;
-            m_LatencyText.autoSizeTextContainer = true;
-
-            m_LatencyText.text = "Network Latency Enabled";
-
-            var statUIRectTransform = statUI.GetComponent<RectTransform>();
-            NetworkOverlay.Instance.AddToUI(statUIRectTransform);
+            NetworkOverlay.Instance.AddTextToUI("UI Latency Warning Text", "Network Latency Enabled", out m_LatencyText);
         }
     }
 }

Assets/BossRoom/Scripts/Infrastructure/Editor/NetworkOverlay.cs

@@ -1,3 +1,4 @@
+using TMPro;
 using UnityEngine;
 using UnityEngine.UI;
 
@@ -18,6 +19,21 @@ void Awake()
             DontDestroyOnLoad(this);
         }
 
+        public void AddTextToUI(string gameObjectName, string defaultText, out TextMeshProUGUI textComponent)
+        {
+            var rootGO = new GameObject(gameObjectName);
+            textComponent = rootGO.AddComponent<TextMeshProUGUI>();
+            textComponent.fontSize = 32;
+            textComponent.text = defaultText;
+            textComponent.horizontalAlignment = HorizontalAlignmentOptions.Left;
+            textComponent.verticalAlignment = VerticalAlignmentOptions.Middle;
+            textComponent.raycastTarget = false;
+            textComponent.autoSizeTextContainer = true;
+
+            var rectTransform = rootGO.GetComponent<RectTransform>();
+            AddToUI(rectTransform);
+        }
+
         public void AddToUI(RectTransform displayTransform)
         {
             if (m_VerticalLayoutTransform == null)

Assets/BossRoom/Scripts/Infrastructure/NetworkStats.cs

@@ -91,24 +91,9 @@ void CreateNetworkStatsText()
                 "No NetworkOverlay object part of scene. Add NetworkOverlay prefab to bootstrap scene!");
 
             string hostType = IsHost ? "Host" : IsClient ? "Client" : "Unknown";
-            InitializeTextLine($"Type: {hostType}", out m_TextHostType);
-            InitializeTextLine("No Stat", out m_TextStat);
-            InitializeTextLine("", out m_TextBadNetworkConditions);
-        }
-
-        void InitializeTextLine(string defaultText, out TextMeshProUGUI textComponent)
-        {
-            var rootGO = new GameObject("UI Stat Text");
-            textComponent = rootGO.AddComponent<TextMeshProUGUI>();
-            textComponent.fontSize = 32;
-            textComponent.text = defaultText;
-            textComponent.horizontalAlignment = HorizontalAlignmentOptions.Left;
-            textComponent.verticalAlignment = VerticalAlignmentOptions.Middle;
-            textComponent.raycastTarget = false;
-            textComponent.autoSizeTextContainer = true;
-
-            var rectTransform = rootGO.GetComponent<RectTransform>();
-            Editor.NetworkOverlay.Instance.AddToUI(rectTransform);
+            Editor.NetworkOverlay.Instance.AddTextToUI("UI Host Type Text", $"Type: {hostType}", out m_TextHostType);
+            Editor.NetworkOverlay.Instance.AddTextToUI("UI Stat Text", "No Stat", out m_TextStat);
+            Editor.NetworkOverlay.Instance.AddTextToUI("UI Bad Conditions Text", "", out m_TextBadNetworkConditions);
         }
 
         void FixedUpdate()