added unregistering of custom named message on dispose

Author: LPLafontaineB

Assets/BossRoom/Scripts/Shared/Infrastructure/PubSub/MessageChannel.cs

@@ -16,7 +16,7 @@ public class MessageChannel<T> : IMessageChannel<T>
 
         public bool IsDisposed { get; private set; } = false;
 
-        public void Dispose()
+        public virtual void Dispose()
         {
             if (!IsDisposed)
             {

Assets/BossRoom/Scripts/Shared/Infrastructure/PubSub/NetworkedMessageChannel.cs

@@ -23,12 +23,18 @@ public NetworkedMessageChannel()
             m_Name = $"{typeof(T).FullName}NetworkMessageChannel";
         }
 
-        ~NetworkedMessageChannel()
+        public override void Dispose()
         {
-            if (NetworkManager.Singleton != null && NetworkManager.Singleton.CustomMessagingManager != null)
+            if (!IsDisposed)
             {
-                NetworkManager.Singleton.CustomMessagingManager.UnregisterNamedMessageHandler(m_Name);
+                if (NetworkManager.Singleton != null && NetworkManager.Singleton.CustomMessagingManager != null)
+                {
+                    NetworkManager.Singleton.CustomMessagingManager.UnregisterNamedMessageHandler(m_Name);
+                }
+
+                m_HasRegisteredHandler = false;
             }
+            base.Dispose();
         }
 
         public override IDisposable Subscribe(Action<T> handler)