Removing useless ForceNetworkSerializeByMemcpy for FixedString32Bytes

SamuelBellomo · SamuelBellomo · commit 1951323393df · 2022-06-09T18:19:11.000-04:00
Update changelog
diff --git a/Assets/Scripts/Gameplay/GameplayObjects/NetworkNameState.cs b/Assets/Scripts/Gameplay/GameplayObjects/NetworkNameState.cs
@@ -19,7 +19,7 @@ public class NetworkNameState : NetworkBehaviour
     /// </summary>
     public struct FixedPlayerName : INetworkSerializable
     {
-        ForceNetworkSerializeByMemcpy<FixedString32Bytes> m_Name; // using ForceNetworkSerializeByMemcpy to force compatibility between FixedString and NetworkSerializable
+        FixedString32Bytes m_Name;
         public void NetworkSerialize<T>(BufferSerializer<T> serializer) where T : IReaderWriter
         {
             serializer.SerializeValue(ref m_Name);
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -20,7 +20,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
 * Updated boss room's root scene to automatically load child scenes at editor time (#653)
 
 ### Changed
-* Bump NGO to pre.10 (#678) --> Fix in Boss Room related to the connection approval breaking change.
+* Bump NGO to pre.10 (#678) --> Fix in Boss Room related to the connection approval breaking change. Removing useless ForceNetworkSerializeByMemcpy for player names.
 * Bump Boss Room to Unity 2021 [MTT-3022] (#620)
 * Remove initial ugs popup [MTT-3563] (#650) --> Users who do not use UGS will no longer receive a popup when starting the application telling them how to set it up. It is replaced with a tooltip that appears when hovering on the "Start with Lobby" button with the cursor.
 * Folders and assemblies refactor MTT-2623, MTT-2615 (#628) --> work in progress
diff --git a/Packages/com.unity.multiplayer.samples.coop/CHANGELOG.md b/Packages/com.unity.multiplayer.samples.coop/CHANGELOG.md
@@ -11,7 +11,7 @@
 ### Removed
 *
 ### Fixed
-*
+* Fixed breaking change from NetworkTransform in ClientNetworkTransform
 ## [1.2.0-pre] - 2022-04-28
 ### Added
 * Client network transform move to samples [MTT-3406] (#629) --> You can now use Boss Room's Utilities package to import ClientNetworkTransform using this line in your manifest file     

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ public class NetworkNameState : NetworkBehaviour`
`19`	`19`	`/// </summary>`
`20`	`20`	`public struct FixedPlayerName : INetworkSerializable`
`21`	`21`	`{`
`22`		`- ForceNetworkSerializeByMemcpy<FixedString32Bytes> m_Name; // using ForceNetworkSerializeByMemcpy to force compatibility between FixedString and NetworkSerializable`
	`22`	`+ FixedString32Bytes m_Name;`
`23`	`23`	`public void NetworkSerialize<T>(BufferSerializer<T> serializer) where T : IReaderWriter`
`24`	`24`	`{`
`25`	`25`	`serializer.SerializeValue(ref m_Name);`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`### Removed`
`12`	`12`	`*`
`13`	`13`	`### Fixed`
`14`		`-*`
	`14`	`+* Fixed breaking change from NetworkTransform in ClientNetworkTransform`
`15`	`15`	`## [1.2.0-pre] - 2022-04-28`
`16`	`16`	`### Added`
`17`	`17`	`* Client network transform move to samples [MTT-3406] (#629) --> You can now use Boss Room's Utilities package to import ClientNetworkTransform using this line in your manifest file`