Added todo comment for better way to wait

LPLafontaineB · SamuelBellomo · web-flow · commit 2862e59d7c7f · 2022-03-14T11:06:02.000-04:00
Co-authored-by: Sam Bellomo &lt;71790295+SamuelBellomo@users.noreply.github.com&gt;
diff --git a/Assets/BossRoom/Scripts/Shared/Net/ConnectionManagement/ClientGameNetPortal.cs b/Assets/BossRoom/Scripts/Shared/Net/ConnectionManagement/ClientGameNetPortal.cs
@@ -204,6 +204,7 @@ private IEnumerator TryToReconnect(string lobbyCode)
                     var leavingLobby = true;
                     m_LobbyServiceFacade.ForceLeaveLobbyAttempt(() => leavingLobby = false, () => leavingLobby = false);
                     yield return new WaitWhile(() => leavingLobby); // This is not a clean way of doing this, ideally we would want to replace that logic with a proper await.
+                    // todo should use yield return new WaitUntil(() => task.IsCompleted);
                     var joiningLobby = true;
                     m_LobbyServiceFacade.JoinLobbyAsync("", lobbyCode, onSuccess: lobby =>
                         {

Original file line number	Diff line number	Diff line change
`@@ -204,6 +204,7 @@ private IEnumerator TryToReconnect(string lobbyCode)`
`204`	`204`	`var leavingLobby = true;`
`205`	`205`	`m_LobbyServiceFacade.ForceLeaveLobbyAttempt(() => leavingLobby = false, () => leavingLobby = false);`
`206`	`206`	`yield return new WaitWhile(() => leavingLobby); // This is not a clean way of doing this, ideally we would want to replace that logic with a proper await.`
	`207`	`+ // todo should use yield return new WaitUntil(() => task.IsCompleted);`
`207`	`208`	`var joiningLobby = true;`
`208`	`209`	`m_LobbyServiceFacade.JoinLobbyAsync("", lobbyCode, onSuccess: lobby =>`
`209`	`210`	`{`