fix: dead player not dead when reconnecting [MTT-2965] (#583)

* Moved HP LifeState initialization to ServerCharacter and adding LifeState initialization for reconnecting players with 0 HP or less

Author: LPLafontaineB

Assets/BossRoom/Scripts/Server/Game/Character/ServerAnimationHandler.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections;
 using Unity.Netcode;
 using Unity.Netcode.Components;
 using UnityEngine;
@@ -22,7 +23,18 @@ public override void OnNetworkSpawn()
         {
             if (IsServer)
             {
-                m_NetworkLifeState.LifeState.OnValueChanged += OnLifeStateChanged;
+                // Wait until next frame before registering on OnValueChanged to make sure NetworkAnimator has spawned before.
+                StartCoroutine(WaitToRegisterOnLifeStateChanged());
+            }
+        }
+
+        IEnumerator WaitToRegisterOnLifeStateChanged()
+        {
+            yield return new WaitForEndOfFrame();
+            m_NetworkLifeState.LifeState.OnValueChanged += OnLifeStateChanged;
+            if (m_NetworkLifeState.LifeState.Value != LifeState.Alive)
+            {
+                OnLifeStateChanged(LifeState.Alive, m_NetworkLifeState.LifeState.Value);
             }
         }
 

Assets/BossRoom/Scripts/Server/Game/Character/ServerCharacter.cs

@@ -85,6 +85,7 @@ public override void OnNetworkSpawn()
                     var startingAction = new ActionRequestData() { ActionTypeEnum = m_StartingAction };
                     PlayAction(ref startingAction);
                 }
+                InitializeHitPoints();
             }
         }
 
@@ -105,6 +106,24 @@ public override void OnNetworkDespawn()
             }
         }
 
+        void InitializeHitPoints()
+        {
+            NetState.HitPoints = NetState.CharacterClass.BaseHP.Value;
+
+            if (!IsNpc)
+            {
+                SessionPlayerData? sessionPlayerData = SessionManager<SessionPlayerData>.Instance.GetPlayerData(OwnerClientId);
+                if (sessionPlayerData is {HasCharacterSpawned: true})
+                {
+                    NetState.HitPoints = sessionPlayerData.Value.CurrentHitPoints;
+                    if (NetState.HitPoints <= 0)
+                    {
+                        NetState.LifeState = LifeState.Fainted;
+                    }
+                }
+            }
+        }
+
         /// <summary>
         /// Play a sequence of actions!
         /// </summary>

Assets/BossRoom/Scripts/Server/Game/Character/ServerCharacterMovement.cs

@@ -141,7 +141,7 @@ public bool IsMoving()
         /// </summary>
         public void CancelMove()
         {
-            m_NavPath.Clear();
+            m_NavPath?.Clear();
             m_MovementState = MovementState.Idle;
         }
 

Assets/BossRoom/Scripts/Shared/Game/Entity/NetworkCharacterState.cs

@@ -110,26 +110,6 @@ public LifeState LifeState
         /// </summary>
         public event Action<Vector3> ReceivedClientInput;
 
-        public override void OnNetworkSpawn()
-        {
-            if (!IsServer) return;
-            HitPoints = GetInitialHitPoints();
-        }
-
-        int GetInitialHitPoints()
-        {
-            if (!IsNpc)
-            {
-                SessionPlayerData? sessionPlayerData = SessionManager<SessionPlayerData>.Instance.GetPlayerData(OwnerClientId);
-                if (sessionPlayerData is { HasCharacterSpawned: true })
-                {
-                    return sessionPlayerData.Value.CurrentHitPoints;
-                }
-            }
-
-            return CharacterClass.BaseHP.Value;
-        }
-
         /// <summary>
         /// RPC to send inputs for this character from a client to a server.
         /// </summary>