Merge branch 'sam/feat/pre-commit-hook' into feature/bump-2021

* sam/feat/pre-commit-hook:
  cleanup
  adding git lfs support
  something didn't work, reverting file
  Adding project id detection
  initial pass at hooks

Author: SamuelBellomo

RepoUtilities/InstallHooks.bat

@@ -0,0 +1,4 @@
+echo "starting"
+xcopy pre-commit.toInstall ../.git/hooks/pre-commit
+echo "checking if python is installed, if the following errors out, please install python3"
+python3 -c "print('done installing')"

RepoUtilities/InstallHooks.sh

@@ -0,0 +1,6 @@
+echo "starting"
+cp pre-commit.toInstall ../.git/hooks/pre-commit
+chmod +x ../.git/hooks/pre-commit
+echo "checking if python is installed, if the following errors out, please install python3"
+
+python3 -c "print('done installing')"

RepoUtilities/pre-commit.py

@@ -0,0 +1,30 @@
+import json
+import sys
+import os
+import re
+
+def FailCommit(reason):
+    print("Oh no! Bad commit! "+reason)
+    sys.exit(1)
+
+def GetStagedFileContent(filePath):
+    cmd = 'git show :' + filePath
+    stream = os.popen(cmd)
+    return stream.read()
+
+def GetLFSStagedFileContent(filePath):
+    cmd = f"git cat-file blob :{filePath} | git lfs smudge"
+    stream = os.popen(cmd)
+    return stream.read()
+
+output = GetStagedFileContent('Packages/manifest.json')
+packages = json.loads(output)['dependencies']
+if ('com.unity.multiplayer.virtualprojects' in packages):
+    FailCommit("Virtual projects in packages")
+if ('github' in packages['com.unity.multiplayer.tools'].lower()):
+    FailCommit("Tools using github package")
+
+content = GetLFSStagedFileContent('ProjectSettings/ProjectSettings.asset')
+res = re.search(r'.*cloudProjectId:.*\w+\s*\n', content) != None
+if res:
+    FailCommit("Detected cloud project id in project settings")

RepoUtilities/pre-commit.toInstall

@@ -0,0 +1 @@
+python3 RepoUtilities/pre-commit.py