Lobby service integration (#480)

* Adding DIScope - an implementation of dependency injection container pattern

* Reformat

* Adding MessageChannel - a pub-sub message-passing pattern

also adding DIScope extensions - this messaging system is particularly useful with DI and the extension provided allows to easily bind all the necessary interfaces to the DI Scope for easy retrieval of either publisher or subscriber interfaces to the message channel

* Formatting

* UpdateRunner - single Update, usable by non-mbh classes and capable of slower update rates than the FPS

* Formatting

* Initial UI work to add a toggle for selecting public Lobbies

Further work is needed to integrate a nice-looking list of public lobbies

* compilation error fix (After rebase)

* Created most of the necessary UI for lobby creation and joining

* moved logic from MainMenuUI to ClientMainMenuState

* #

* #

* WIP work on porting Lobby Sample code to the Boss Room project

* WIP initialization of the lobby system

Added some more capability to the DI system so that it can handle lazy initialization.
Working on the temporary placeholder class LobbyUIManager that contains setup for the di scope of the lobby system and will do other initialization and reactivity

* lobby ui manager wiring

preparation work to refactor the PopupPanel and put lobbies in front of all of our modes of connection

* #

* lobby ui manager injects it's GOs automatically

* Added new popup prefab and moved logic to main menu state

* wip main menu and login popup prefabs

* More work on the LobbyPopup UI

* #

* #

* Fixed DI issues

DI scope now reliably works with method and constructor based injection.
Renamed and refactored UpdateSlow into UpdateRunner - a tool for non-monobehs to run their update logic and for monobehs that want to save on an extra Update call.
Added Bootstrap.cs - a class where we set up core dependencies and that then proceeds to load the first logical scene.

* rename fix

* Updated MainMenu to use LobbyPopup, removed old UI elements

also renamed LobbyUIManager to LobbyUIMediator which is a more accurate reflection of what this class does (an entrypoint to all things LobbyUI)

* #

* Private Toggle had raycast target disabled and was un-toggleable

* working on lobby creation and the appropriate UI callbacks and reacitons

* #

* Renamed UIFactory to GameObjectFactory, fixed the issue with lobby retrieval exceptions (parsing error)

* #

* #

* #

* #

* #

* Renamed error popup message into UnityServiceErrorMessage

* #

* Cleanups and refactorings

* wip IP connection on lobby join (through creation and through the join ui both)

* passing lobby data immediately on creation (because we can, so why wait)

* Sometimes we want to block ui while fetching lobbies and other times we do it in the background and UI should not be blocked,

* #

* passing correct ip from UI

* copied relay code from lobby sample

* #

* backup copies of my versions of scenes for easier rebasing on dev

* re-did changes to startup scene

* #

* moved some of the dependency registrations to the Bootstrap, where we take care of stuff that persists while the app is alive

* formatting

* #

* passed important dependency to the bootstrap class

* #

* post-rebase cleanup

* fixed an issue with code 404 returned on lobby refresh request

* Moved OnApplicationQuit Lobby quit attempt logic into Bootstrap, where we actually bind our original dependencies

* �#

* Bootstrap is now responsible for also containing applicaiton quit logic (so that we can control what services need shutdown messages)

RoomNameBox now shows the code for either the IP or Relay based connection;
Removed Photon Relay join option.

* Added support for ParrelSync-based testing for Unity Services

did it by utilizing Profiles features of Unity Authentication and passing custom argument to the

* Stop lobby tracking if left lobby (ie quit the game or went back to main menu)

* fixed bad default IP (used for localhost connection)

* #

* Fixed unclickable menu problem

* Cleanup

* Connected existing relay logic with some minor alterations to the lobby flow

Cleaned up some of the unnecessary code inherited from the lobby sample, more of this to come

* #

* Got relay-based connection to work

* Removed unnecessary data visualization

* simplified mainmenustate prefab

* Bootstrap renamed to ApplicationController to better reflect it's intent

* Removed Identity system and replaced it with a simpled Auth service wrapper

* Fixed a blocked UI bug

Code cleanup

* #

* applied formatting

* Removed unused code

* accidentally reintroduced a class that was removed earlier

* re-added lobby package

* using cleanup and removal of unused enums

* review feedback wip

* Update Assets/BossRoom/Scripts/Client/UI/UITinter.cs

Co-authored-by: Ben Randall <[email protected]>

* Update Assets/BossRoom/Scripts/Client/UI/UITinter.cs

Co-authored-by: Ben Randall <[email protected]>

* #

* Review comments wip

 - LobbyServiceData is no longer an Observed and now is using dedicated pub-sub;
 - Name changes (with requisite serialized object updates) to keep in line with our coding conventions
 - UITinter was simplified and now is always asking for an int - no more bool-based API
 - Name changes to the AutoInjected lists - now they're called very descriptively - GameObjectsThatWillBeInjectedAutomatically
 - Passing in dependencies instead of manually resolving them in MainMenuState

* Build error fix

* Removed verbs from Lobby-related UI class names

* Update Assets/BossRoom/Scripts/Client/Game/State/ClientMainMenuState.cs

Co-authored-by: LPLafontaineB <[email protected]>

* #

* Quit logic for lobbies has been moved to LobbyAsyncRequests

* Removed redundant cancellationtokensource-realted code

* Minor API change for AuthenticationAPIInterface

* #

* Added BufferedMessageChannel - it would call the subscriber immediately if it has a buffered message in it already

Will be used to refactor out the "data singletons" and to just define message channels where that data would sit in an observable state.

* #

* Fun little regex mistake fixed

* #

* AuthenticationServiceFacade rename

* simpligied RateLimitCooldown class

* Lobby API Wrapper refactorings

 - Primary entrypoint to the Lobby stuff is now called LobbyServiceFacade
 - Many naming adustments
 - it cleanly encapsulates it's implementation details and passes them around using a child DI scope
 - Observable was removed (for UI purposes), however there is still a need for a Changed event for LocalUser and LocalLobby

* #

* #

* Bad regex kicking out '.'

* Fixing scene references after refactorings

* Fixed issue with OnlineMode not being set for a new lobby

* Update ui for room name box immediately

* Leave lobby when quitting game or leaving char select

* Fixed DI bug where if you access the same object through different interfaces it would create multiple objects

* #

* naming fix

* Added 3 interface binding in DIScope

* Removed old PopupPanel prefab

* MainMenuState didn't have UICanvas set to autoinject

* Class naming fix

* Cleaned up photon usage

* Code comments fix

* Added command line argument parsing which allows us to set a different auth profile for the client

* MessageChannel internal action queue doc

* Naming and API tweaks

* UpdateRunner implementation cleaned up

brought in line with how MessageChannel is implemented

* preventing endless re-queing of fetch lobbies

we have a fetch call that's being called from time to time as is

* ui testing

* #

* Update Assets/BossRoom/Scripts/Shared/Infrastructure/PubSub/MessageChannel.cs

Co-authored-by: Sam Bellomo <[email protected]>

* code style, renamings

* Update Assets/BossRoom/Scripts/Client/UI/Lobby/LobbyCreationUI.cs

Co-authored-by: Fernando Cortez <[email protected]>

* #

* #

* Cleaned up the remainders of Photon package

* relay package upgrade

* code style pass

* Room Name -> Join Code rename in the char select UI

* Increased the delay for lobby update slightly

more formatting changes

* LobbyJoiningUI InjectDependenciesAndInstantiate -> InjectDependenciesAndInitialize

* Added a filter and order usage within LobbyAPIInterface

now there should be no need to filter lobbies out locally

* Removed Photon Transport form the NM prefab

* #

* naming adjustment

* unused comment

* #

* namespace adjustment

* LobbyUIMediator relayjoinedfailed logic moved into internal scope

* unlinked the project from project id

Co-authored-by: Ben Randall <[email protected]>
Co-authored-by: LPLafontaineB <[email protected]>
Co-authored-by: Sam Bellomo <[email protected]>
Co-authored-by: Fernando Cortez <[email protected]>

Author: 5 people

Assets/BossRoom/Prefabs/NetworkingManager.prefab

@@ -29,7 +29,7 @@ Transform:
   m_LocalScale: {x: 1, y: 1, z: 1}
   m_Children: []
   m_Father: {fileID: 5436007408952557925}
-  m_RootOrder: 2
+  m_RootOrder: 1
   m_LocalEulerAnglesHint: {x: 0, y: 0, z: 0}
 --- !u!114 &5486862276979889515
 MonoBehaviour:
@@ -44,68 +44,17 @@ MonoBehaviour:
   m_Name: 
   m_EditorClassIdentifier: 
   m_ProtocolType: 0
-  m_MaximumPacketSize: 2000
   m_MaxPacketQueueSize: 512
-  m_SendQueueBatchSize: 16000
+  m_MaxPayloadSize: 16000
+  m_MaxSendQueueSize: 98304
   m_HeartbeatTimeoutMS: 500
   m_ConnectTimeoutMS: 1000
   m_MaxConnectAttempts: 60
   m_DisconnectTimeoutMS: 30000
   ConnectionData:
     Address: 127.0.0.1
     Port: 7777
---- !u!1 &409269880
-GameObject:
-  m_ObjectHideFlags: 0
-  m_CorrespondingSourceObject: {fileID: 0}
-  m_PrefabInstance: {fileID: 0}
-  m_PrefabAsset: {fileID: 0}
-  serializedVersion: 6
-  m_Component:
-  - component: {fileID: 409269881}
-  - component: {fileID: 409269882}
-  m_Layer: 0
-  m_Name: PhotonTransport
-  m_TagString: Untagged
-  m_Icon: {fileID: 0}
-  m_NavMeshLayer: 0
-  m_StaticEditorFlags: 0
-  m_IsActive: 1
---- !u!4 &409269881
-Transform:
-  m_ObjectHideFlags: 0
-  m_CorrespondingSourceObject: {fileID: 0}
-  m_PrefabInstance: {fileID: 0}
-  m_PrefabAsset: {fileID: 0}
-  m_GameObject: {fileID: 409269880}
-  m_LocalRotation: {x: 0, y: 0, z: 0, w: 1}
-  m_LocalPosition: {x: 0, y: 0, z: 0}
-  m_LocalScale: {x: 1, y: 1, z: 1}
-  m_Children: []
-  m_Father: {fileID: 5436007408952557925}
-  m_RootOrder: 0
-  m_LocalEulerAnglesHint: {x: 0, y: 0, z: 0}
---- !u!114 &409269882
-MonoBehaviour:
-  m_ObjectHideFlags: 0
-  m_CorrespondingSourceObject: {fileID: 0}
-  m_PrefabInstance: {fileID: 0}
-  m_PrefabAsset: {fileID: 0}
-  m_GameObject: {fileID: 409269880}
-  m_Enabled: 1
-  m_EditorHideFlags: 0
-  m_Script: {fileID: 11500000, guid: 52c005b32a68a254cbe502a4e5cb8eb6, type: 3}
-  m_Name: 
-  m_EditorClassIdentifier: 
-  m_NickName: 
-  m_RoomName: 
-  m_MaxPlayers: 16
-  m_NetworkDeliveryEventCodesStartRange: 130
-  m_AttachSupportLogger: 0
-  m_BatchMode: 1
-  m_SendQueueBatchSize: 100000
-  m_BatchedTransportEventCode: 129
-  m_KickEventCode: 130
+    ServerListenAddress: 
 --- !u!1 &503411707
 GameObject:
   m_ObjectHideFlags: 0
@@ -135,7 +84,7 @@ Transform:
   m_LocalScale: {x: 1, y: 1, z: 1}
   m_Children: []
   m_Father: {fileID: 5436007408952557925}
-  m_RootOrder: 3
+  m_RootOrder: 2
   m_LocalEulerAnglesHint: {x: 0, y: 0, z: 0}
 --- !u!114 &503411709
 MonoBehaviour:
@@ -150,16 +99,17 @@ MonoBehaviour:
   m_Name: 
   m_EditorClassIdentifier: 
   m_ProtocolType: 1
-  m_MaximumPacketSize: 1400
   m_MaxPacketQueueSize: 256
-  m_SendQueueBatchSize: 32000
+  m_MaxPayloadSize: 32000
+  m_MaxSendQueueSize: 98304
   m_HeartbeatTimeoutMS: 500
   m_ConnectTimeoutMS: 1000
   m_MaxConnectAttempts: 60
   m_DisconnectTimeoutMS: 30000
   ConnectionData:
     Address: 127.0.0.1
     Port: 7777
+    ServerListenAddress: 
 --- !u!1 &5436007408952557947
 GameObject:
   m_ObjectHideFlags: 0
@@ -189,7 +139,6 @@ Transform:
   m_LocalPosition: {x: 0, y: 0, z: 0}
   m_LocalScale: {x: 1, y: 1, z: 1}
   m_Children:
-  - {fileID: 409269881}
   - {fileID: 1861090270400447367}
   - {fileID: 347284043}
   - {fileID: 503411708}
@@ -209,7 +158,6 @@ MonoBehaviour:
   m_Name: 
   m_EditorClassIdentifier: 
   m_IpHostTransport: {fileID: 5486862276979889515}
-  m_RelayTransport: {fileID: 409269882}
   m_UnityRelayTransport: {fileID: 503411709}
 --- !u!114 &5436007408952557924
 MonoBehaviour:
@@ -223,7 +171,6 @@ MonoBehaviour:
   m_Script: {fileID: 11500000, guid: 593a2fe42fa9d37498c96f9a383b6521, type: 3}
   m_Name: 
   m_EditorClassIdentifier: 
-  DontDestroy: 1
   RunInBackground: 1
   LogLevel: 1
   NetworkConfig:
@@ -315,7 +262,7 @@ Transform:
   m_LocalScale: {x: 1, y: 1, z: 1}
   m_Children: []
   m_Father: {fileID: 5436007408952557925}
-  m_RootOrder: 1
+  m_RootOrder: 0
   m_LocalEulerAnglesHint: {x: 0, y: 0, z: 0}
 --- !u!114 &7738483995325753316
 MonoBehaviour:

Assets/BossRoom/Prefabs/State/MainMenuState.prefab

@@ -8,29 +8,37 @@ GameObject:
   m_PrefabAsset: {fileID: 0}
   serializedVersion: 6
   m_Component:
-  - component: {fileID: 8576152884213668001}
+  - component: {fileID: 3747962111577947793}
   - component: {fileID: 8576152884213668000}
+  - component: {fileID: 2665876610389888237}
+  - component: {fileID: 7369153188685295691}
+  - component: {fileID: 493749757375256148}
   m_Layer: 0
   m_Name: MainMenuState
   m_TagString: Untagged
   m_Icon: {fileID: 0}
   m_NavMeshLayer: 0
   m_StaticEditorFlags: 0
   m_IsActive: 1
---- !u!4 &8576152884213668001
-Transform:
+--- !u!224 &3747962111577947793
+RectTransform:
   m_ObjectHideFlags: 0
   m_CorrespondingSourceObject: {fileID: 0}
   m_PrefabInstance: {fileID: 0}
   m_PrefabAsset: {fileID: 0}
   m_GameObject: {fileID: 8576152884213668003}
   m_LocalRotation: {x: 0, y: 0, z: 0, w: 1}
   m_LocalPosition: {x: 0, y: 0, z: 0}
-  m_LocalScale: {x: 1, y: 1, z: 1}
+  m_LocalScale: {x: 0, y: 0, z: 0}
   m_Children: []
   m_Father: {fileID: 0}
   m_RootOrder: 0
   m_LocalEulerAnglesHint: {x: 0, y: 0, z: 0}
+  m_AnchorMin: {x: 0, y: 0}
+  m_AnchorMax: {x: 0, y: 0}
+  m_AnchoredPosition: {x: 0, y: 0}
+  m_SizeDelta: {x: 0, y: 0}
+  m_Pivot: {x: 0, y: 0}
 --- !u!114 &8576152884213668000
 MonoBehaviour:
   m_ObjectHideFlags: 0
@@ -43,3 +51,70 @@ MonoBehaviour:
   m_Script: {fileID: 11500000, guid: ab10fd7c6aa7d36438f5ac1c0ebfadbb, type: 3}
   m_Name: 
   m_EditorClassIdentifier: 
+  _autoInjected:
+  - {fileID: 0}
+  m_NameGenerationData: {fileID: 11400000, guid: cc0e4025ad893614a8db0d9c10bf7c4f, type: 2}
+  m_lobbyUIMediator: {fileID: 0}
+  m_mainMenuButtons: {fileID: 0}
+  m_signInSpinner: {fileID: 0}
+--- !u!223 &2665876610389888237
+Canvas:
+  m_ObjectHideFlags: 0
+  m_CorrespondingSourceObject: {fileID: 0}
+  m_PrefabInstance: {fileID: 0}
+  m_PrefabAsset: {fileID: 0}
+  m_GameObject: {fileID: 8576152884213668003}
+  m_Enabled: 1
+  serializedVersion: 3
+  m_RenderMode: 0
+  m_Camera: {fileID: 0}
+  m_PlaneDistance: 100
+  m_PixelPerfect: 0
+  m_ReceivesEvents: 1
+  m_OverrideSorting: 0
+  m_OverridePixelPerfect: 0
+  m_SortingBucketNormalizedSize: 0
+  m_AdditionalShaderChannelsFlag: 25
+  m_SortingLayerID: 0
+  m_SortingOrder: 0
+  m_TargetDisplay: 0
+--- !u!114 &7369153188685295691
+MonoBehaviour:
+  m_ObjectHideFlags: 0
+  m_CorrespondingSourceObject: {fileID: 0}
+  m_PrefabInstance: {fileID: 0}
+  m_PrefabAsset: {fileID: 0}
+  m_GameObject: {fileID: 8576152884213668003}
+  m_Enabled: 1
+  m_EditorHideFlags: 0
+  m_Script: {fileID: 11500000, guid: 0cd44c1031e13a943bb63640046fad76, type: 3}
+  m_Name: 
+  m_EditorClassIdentifier: 
+  m_UiScaleMode: 1
+  m_ReferencePixelsPerUnit: 100
+  m_ScaleFactor: 1
+  m_ReferenceResolution: {x: 1920, y: 1080}
+  m_ScreenMatchMode: 0
+  m_MatchWidthOrHeight: 0.506
+  m_PhysicalUnit: 3
+  m_FallbackScreenDPI: 96
+  m_DefaultSpriteDPI: 96
+  m_DynamicPixelsPerUnit: 1
+  m_PresetInfoIsWorld: 0
+--- !u!114 &493749757375256148
+MonoBehaviour:
+  m_ObjectHideFlags: 0
+  m_CorrespondingSourceObject: {fileID: 0}
+  m_PrefabInstance: {fileID: 0}
+  m_PrefabAsset: {fileID: 0}
+  m_GameObject: {fileID: 8576152884213668003}
+  m_Enabled: 1
+  m_EditorHideFlags: 0
+  m_Script: {fileID: 11500000, guid: dc42784cf147c0c48a680349fa168899, type: 3}
+  m_Name: 
+  m_EditorClassIdentifier: 
+  m_IgnoreReversedGraphics: 1
+  m_BlockingObjects: 0
+  m_BlockingMask:
+    serializedVersion: 2
+    m_Bits: 4294967295

Assets/BossRoom/Prefabs/UI/CharacterSelectCanvas.prefab

@@ -999,7 +999,7 @@ MonoBehaviour:
   m_OnCullStateChanged:
     m_PersistentCalls:
       m_Calls: []
-  m_text: 'Room Name: '
+  m_text: 'Join Code: '
   m_isRightToLeft: 0
   m_fontAsset: {fileID: 11400000, guid: 9641ce046d2227445b9684161a165f68, type: 2}
   m_sharedMaterial: {fileID: -4106257185398102161, guid: 9641ce046d2227445b9684161a165f68, type: 2}
@@ -3757,14 +3757,14 @@ PrefabInstance:
       objectReference: {fileID: 21300000, guid: bb7d37d2a40813048883c2696e975eac, type: 3}
     m_RemovedComponents: []
   m_SourcePrefab: {fileID: 100100000, guid: ff848390065bf914fb60582f4d872815, type: 3}
---- !u!224 &4148434299776943719 stripped
+--- !u!224 &8367260898428394609 stripped
 RectTransform:
-  m_CorrespondingSourceObject: {fileID: 7773346133266671123, guid: ff848390065bf914fb60582f4d872815, type: 3}
+  m_CorrespondingSourceObject: {fileID: 2768642224677944325, guid: ff848390065bf914fb60582f4d872815, type: 3}
   m_PrefabInstance: {fileID: 5940892340993679476}
   m_PrefabAsset: {fileID: 0}
---- !u!224 &8367260898428394609 stripped
+--- !u!224 &4148434299776943719 stripped
 RectTransform:
-  m_CorrespondingSourceObject: {fileID: 2768642224677944325, guid: ff848390065bf914fb60582f4d872815, type: 3}
+  m_CorrespondingSourceObject: {fileID: 7773346133266671123, guid: ff848390065bf914fb60582f4d872815, type: 3}
   m_PrefabInstance: {fileID: 5940892340993679476}
   m_PrefabAsset: {fileID: 0}
 --- !u!1001 &5940892341121358677
@@ -4829,14 +4829,14 @@ PrefabInstance:
       objectReference: {fileID: 21300000, guid: 9781ab5273dea1c4e94c1ab8d4d18b31, type: 3}
     m_RemovedComponents: []
   m_SourcePrefab: {fileID: 100100000, guid: ff848390065bf914fb60582f4d872815, type: 3}
---- !u!224 &8367260899810866543 stripped
+--- !u!224 &4148434300538892153 stripped
 RectTransform:
-  m_CorrespondingSourceObject: {fileID: 2768642224677944325, guid: ff848390065bf914fb60582f4d872815, type: 3}
+  m_CorrespondingSourceObject: {fileID: 7773346133266671123, guid: ff848390065bf914fb60582f4d872815, type: 3}
   m_PrefabInstance: {fileID: 5940892341839497578}
   m_PrefabAsset: {fileID: 0}
---- !u!224 &4148434300538892153 stripped
+--- !u!224 &8367260899810866543 stripped
 RectTransform:
-  m_CorrespondingSourceObject: {fileID: 7773346133266671123, guid: ff848390065bf914fb60582f4d872815, type: 3}
+  m_CorrespondingSourceObject: {fileID: 2768642224677944325, guid: ff848390065bf914fb60582f4d872815, type: 3}
   m_PrefabInstance: {fileID: 5940892341839497578}
   m_PrefabAsset: {fileID: 0}
 --- !u!1001 &5940892341869088767