feat: move session manager and relay utilities to utilities package (#438)

* Moved SessionManager and UnityRelayUtilities to the Utilities package

* Renaming OnClientApprovalCheck method to more meaningful name

* Deleted unused prefab

Author: LPLafontaineB

Assets/BossRoom/Prefabs/SessionManager.prefab

@@ -178,8 +178,10 @@ private void ApprovalCheck(byte[] connectionData, ulong clientId, NetworkManager
 
             Debug.Log("Host ApprovalCheck: connecting client GUID: " + connectionPayload.clientGUID);
 
-            gameReturnStatus = SessionManager<SessionPlayerData>.Instance.OnClientApprovalCheck(clientId, connectionPayload.clientGUID,
-                new SessionPlayerData(clientId, connectionPayload.playerName, m_Portal.AvatarRegistry.GetRandomAvatar().Guid.ToNetworkGuid(), 0, true));
+            gameReturnStatus = SessionManager<SessionPlayerData>.Instance.SetupConnectingPlayerSessionData(clientId, connectionPayload.clientGUID,
+                new SessionPlayerData(clientId, connectionPayload.playerName, m_Portal.AvatarRegistry.GetRandomAvatar().Guid.ToNetworkGuid(), 0, true))
+                ? ConnectStatus.Success
+                : ConnectStatus.LoggedInAgain;
 
             //Test for Duplicate Login.
             if (gameReturnStatus == ConnectStatus.LoggedInAgain)

Assets/BossRoom/Scripts/Shared/Net/ConnectionManagement/ServerGameNetPortal.cs

@@ -109,16 +109,15 @@ private void Clear()
         }
 
         /// <summary>
-        /// Handles the flow when a user is connecting by testing for duplicate logins and populating the session's data.
-        /// Invoked during the approval check and returns the connection status.
+        /// Adds a connecting player's session data if it is a new connection, or updates their session data in case of a reconnection. If the connection is not valid, simply returns false.
         /// </summary>
         /// <param name="clientId">This is the clientId that Netcode assigned us on login. It does not persist across multiple logins from the same client. </param>
         /// <param name="clientGUID">This is the clientGUID that is unique to this client and persists accross multiple logins from the same client</param>
         /// <param name="sessionPlayerData">The player's initial data</param>
-        /// <returns></returns>
-        public ConnectStatus OnClientApprovalCheck(ulong clientId, string clientGUID, T sessionPlayerData)
+        /// <returns>True if the player connection is valid (i.e. not a duplicate connection)</returns>
+        public bool SetupConnectingPlayerSessionData(ulong clientId, string clientGUID, T sessionPlayerData)
         {
-            ConnectStatus gameReturnStatus = ConnectStatus.Success;
+            bool success = true;
 
             //Test for Duplicate Login.
             if (m_ClientData.ContainsKey(clientGUID))
@@ -144,7 +143,7 @@ public ConnectStatus OnClientApprovalCheck(ulong clientId, string clientGUID, T
                     }
                     else
                     {
-                        gameReturnStatus = ConnectStatus.LoggedInAgain;
+                        success = false;
                     }
                 }
                 else
@@ -163,13 +162,13 @@ public ConnectStatus OnClientApprovalCheck(ulong clientId, string clientGUID, T
             }
 
             //Populate our dictionaries with the SessionPlayerData
-            if (gameReturnStatus == ConnectStatus.Success)
+            if (success)
             {
                 m_ClientIDToGuid[clientId] = clientGUID;
                 m_ClientData[clientGUID] = sessionPlayerData;
             }
 
-            return gameReturnStatus;
+            return success;
         }
 
         /// <summary>