better error messages and lobby fix (#550)

fixing issue where it's possible if there's an exception during updating lobby, query count never goes back to 0

Author: SamuelBellomo

Assets/BossRoom/Scripts/Client/UI/PopupPanel.cs

@@ -93,8 +93,7 @@ long SetupPopupPanel(string titleText, string mainText, bool isCloseableByUser =
         {
             if (m_IsPopupShown)
             {
-                Debug.Log("Trying to show popup, but another popup is already being shown.");
-                Debug.Log($"{titleText}. {mainText}");
+                Debug.LogWarning($"Trying to show popup, but another popup is already being shown. Popup: {titleText}. {mainText}");
                 return -1;
             }
 

Assets/BossRoom/Scripts/Client/UI/UnityServicesUIHandler.cs

@@ -48,7 +48,7 @@ void ServiceErrorHandler(UnityServiceErrorMessage error)
                 }
                 default:
                 {
-                    PopupPanel.ShowPopupPanel("Service error", errorMessage);
+            		PopupPanel.ShowPopupPanel("Service error: "+error.Title, errorMessage);
                     break;
                 }
             }

Assets/BossRoom/Scripts/Shared/Net/UnityServices/Lobbies/JoinedLobbyContentHeartbeat.cs

@@ -74,11 +74,11 @@ void OnUpdate(float dt)
 
                 if (m_LocalUser.IsHost)
                 {
-                    m_AwaitingQueryCount++;
-                    m_LobbyServiceFacade.UpdateLobbyDataAsync(m_LocalLobby.GetDataForUnityServices(), OnSuccess, null);
+                    m_AwaitingQueryCount++; // todo this should disapear once we use await correctly. This causes issues at the moment if OnSuccess isn't called properly
+                    m_LobbyServiceFacade.UpdateLobbyDataAsync(m_LocalLobby.GetDataForUnityServices(), OnSuccess, () => m_AwaitingQueryCount--);
                 }
                 m_AwaitingQueryCount++;
-                m_LobbyServiceFacade.UpdatePlayerDataAsync(m_LocalUser.GetDataForUnityServices(), OnSuccess, null);
+                m_LobbyServiceFacade.UpdatePlayerDataAsync(m_LocalUser.GetDataForUnityServices(), OnSuccess, () => m_AwaitingQueryCount--);
             }
 
             void OnSuccess()