spawning after onnetworkspawn sweep, gizmos for in-scene spawn data object

Author: fernando-cortez

Assets/Prefabs/Game/NetworkObjectSpawnData.prefab

@@ -13,7 +13,7 @@ GameObject:
   m_Layer: 0
   m_Name: NetworkObjectSpawnData
   m_TagString: Untagged
-  m_Icon: {fileID: 0}
+  m_Icon: {fileID: 419385456094870383, guid: 0000000000000000d000000000000000, type: 0}
   m_NavMeshLayer: 0
   m_StaticEditorFlags: 0
   m_IsActive: 1

Packages/com.unity.multiplayer.samples.coop/Utilities/Net/NetworkObjectSpawner.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections;
 using System.Collections.Generic;
 using System.Linq;
 using Unity.Netcode;
@@ -11,7 +12,7 @@ namespace Unity.Multiplayer.Samples.Utilities
     /// <summary>
     /// Custom spawning component to be added to a scene GameObject. This component collects NetworkObjects in a scene
     /// marked by a special tag, collects their Transform data, destroys their prefab instance, and performs the dynamic
-    /// spawning of said objects during Netcode for GameObject's OnNetworkSpawn() callback.
+    /// spawning of said objects during Netcode for GameObject's (Netcode) OnNetworkSpawn() callback.
     /// </summary>
     [RequireComponent(typeof(NetcodeHooks))]
     public class NetworkObjectSpawner : MonoBehaviour
@@ -27,7 +28,7 @@ public class NetworkObjectSpawner : MonoBehaviour
 
         const string k_NetworkObjectSpawnerCollectableTag = "NetworkObjectSpawnerCollectable";
 
-        void Start()
+        void Awake()
         {
             m_NetcodeHooks.OnNetworkSpawnHook += OnNetworkSpawn;
         }
@@ -48,6 +49,13 @@ void OnNetworkSpawn()
                 return;
             }
 
+            StartCoroutine(WaitToSpawnNetworkObjects());
+        }
+
+        IEnumerator WaitToSpawnNetworkObjects()
+        {
+            // must wait for Netcode's OnNetworkSpawn() sweep before dynamically spawning
+            yield return new WaitForEndOfFrame();
             SpawnNetworkObjects();
         }
 
@@ -57,7 +65,8 @@ void SpawnNetworkObjects()
             {
                 var spawnedGameObject = Instantiate(m_SpawnObjectData[i].prefabReference,
                     m_SpawnObjectData[i].transform.position,
-                    m_SpawnObjectData[i].transform.rotation);
+                    m_SpawnObjectData[i].transform.rotation,
+                    null);
 
                 spawnedGameObject.transform.localScale = m_SpawnObjectData[i].transform.lossyScale;
                 var spawnedNetworkObject = spawnedGameObject.GetComponent<NetworkObject>();
@@ -68,8 +77,7 @@ void SpawnNetworkObjects()
         }
 
 #if UNITY_EDITOR
-        [ContextMenu("Collect")]
-        public void Collect()
+        public void CollectTaggedPrefabInstances()
         {
             var prefabStage = PrefabStageUtility.GetPrefabStage(gameObject);
 
@@ -121,7 +129,7 @@ public override void OnInspectorGUI()
             if (PrefabStageUtility.GetCurrentPrefabStage() &&
                 GUILayout.Button("Collect tagged prefab instances"))
             {
-                networkObjectSpawner.Collect();
+                networkObjectSpawner.CollectTaggedPrefabInstances();
             }
         }
     }