moving service ui logic to its own class

Author: SamuelBellomo

Assets/BossRoom/Scenes/Startup.unity

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:7b2c33d4681d53ec62b32b7ff2c81123b4457d8dcd8d0b6d643097e74ae36856
-size 35006
+oid sha256:22939a0b19a2e47d1c43cf76d229f2a99bcc8511f03020367645a163b6ab2fba
+size 35402

Assets/BossRoom/Scripts/Client/UI/Lobby/LobbyUIMediator.cs

@@ -26,18 +26,15 @@ public class LobbyUIMediator : MonoBehaviour
         NameGenerationData m_NameGenerationData;
         GameNetPortal m_GameNetPortal;
         ClientGameNetPortal m_ClientNetPortal;
-        private IDisposable m_Subscriptions;
 
         [Inject]
         void InjectDependenciesAndInitialize(
             LobbyServiceFacade lobbyServiceFacade,
-            IPublisher<UnityServiceErrorMessage> unityServiceErrorMessagePublisher,
             LocalLobbyUser localUser,
             LocalLobby localLobby,
             NameGenerationData nameGenerationData,
             GameNetPortal gameNetPortal,
-            ClientGameNetPortal clientGameNetPortal,
-            ISubscriber<UnityServiceErrorMessage> serviceError
+            ClientGameNetPortal clientGameNetPortal
         )
         {
             m_NameGenerationData = nameGenerationData;
@@ -50,24 +47,6 @@ ISubscriber<UnityServiceErrorMessage> serviceError
             RegenerateName();
 
             m_ClientNetPortal.NetworkTimedOut += OnNetworkTimeout;
-            m_Subscriptions = serviceError.Subscribe(ServiceErrorHandler);
-        }
-
-        private void ServiceErrorHandler(UnityServiceErrorMessage error)
-        {
-            var errorMessage = error.Message;
-            if (error.AffectedService == UnityServiceErrorMessage.Service.Lobby)
-            {
-                if ((error.OriginalException as LobbyServiceException).Reason == LobbyExceptionReason.LobbyConflict)
-                {
-                    // LobbyConflict can have multiple causes. Let's add other solutions here if there's other situations that arise for this.
-                    errorMessage += "\nSee logs for possible causes and solution.";
-                    Debug.LogError($"Got service error {error.Message} with LobbyConflict. Possible conflict cause: Trying to play with two builds on the " +
-                              $"same machine. Please use command line arg '{ClientMainMenuState.AuthProfileCommandLineArg} someName' to set a different auth profile.\n");
-                }
-            }
-
-            PopupPanel.ShowPopupPanel("Service error", errorMessage);
         }
 
         void OnDestroy()
@@ -76,8 +55,6 @@ void OnDestroy()
             {
                 m_ClientNetPortal.NetworkTimedOut -= OnNetworkTimeout;
             }
-
-            m_Subscriptions.Dispose();
         }
 
         //Lobby and Relay calls done from UI

Assets/BossRoom/Scripts/Client/UI/UIServices.cs

@@ -0,0 +1,48 @@
+using System;
+using System.Collections;
+using System.Collections.Generic;
+using Unity.Multiplayer.Samples.BossRoom;
+using Unity.Multiplayer.Samples.BossRoom.Client;
+using Unity.Multiplayer.Samples.BossRoom.Shared.Infrastructure;
+using Unity.Multiplayer.Samples.BossRoom.Shared.Net.UnityServices.Infrastructure;
+using Unity.Multiplayer.Samples.BossRoom.Visual;
+using Unity.Services.Lobbies;
+using UnityEngine;
+
+public class UIServices : MonoBehaviour
+{
+    private IDisposable m_Subscriptions;
+
+    void Awake()
+    {
+        DontDestroyOnLoad(gameObject);
+    }
+
+    [Inject]
+    void Initialize(ISubscriber<UnityServiceErrorMessage> serviceError)
+    {
+        m_Subscriptions = serviceError.Subscribe(ServiceErrorHandler);
+    }
+
+    private void ServiceErrorHandler(UnityServiceErrorMessage error)
+    {
+        var errorMessage = error.Message;
+        if (error.AffectedService == UnityServiceErrorMessage.Service.Lobby)
+        {
+            if ((error.OriginalException as LobbyServiceException).Reason == LobbyExceptionReason.LobbyConflict)
+            {
+                // LobbyConflict can have multiple causes. Let's add other solutions here if there's other situations that arise for this.
+                errorMessage += "\nSee logs for possible causes and solution.";
+                Debug.LogError($"Got service error {error.Message} with LobbyConflict. Possible conflict cause: Trying to play with two builds on the " +
+                               $"same machine. Please use command line arg '{ClientMainMenuState.AuthProfileCommandLineArg} someName' to set a different auth profile.\n");
+            }
+        }
+
+        PopupPanel.ShowPopupPanel("Service error", errorMessage);
+    }
+
+    private void OnDestroy()
+    {
+        m_Subscriptions.Dispose();
+    }
+}