fix: wrong base class for ClientConnectedState [MTT-5293] (#801)

* set ClientConnectedState inheriting from OnlineState

* moved k_DtlsConnType constant to ConnectionMethod where it is used

Author: LPLafontaineB

Assets/Scripts/ConnectionManagement/ConnectionMethod.cs

@@ -21,6 +21,7 @@ public abstract class ConnectionMethodBase
         protected ConnectionManager m_ConnectionManager;
         readonly ProfileManager m_ProfileManager;
         protected readonly string m_PlayerName;
+        protected const string k_DtlsConnType = "dtls";
 
         public abstract Task SetupHostConnectionAsync();
 
@@ -128,7 +129,7 @@ public override async Task SetupClientConnectionAsync()
 
             // Configure UTP with allocation
             var utp = (UnityTransport)m_ConnectionManager.NetworkManager.NetworkConfig.NetworkTransport;
-            utp.SetRelayServerData(new RelayServerData(joinedAllocation, OnlineState.k_DtlsConnType));
+            utp.SetRelayServerData(new RelayServerData(joinedAllocation, k_DtlsConnType));
         }
 
         public override async Task SetupHostConnectionAsync()
@@ -152,7 +153,7 @@ public override async Task SetupHostConnectionAsync()
 
             // Setup UTP with relay connection info
             var utp = (UnityTransport)m_ConnectionManager.NetworkManager.NetworkConfig.NetworkTransport;
-            utp.SetRelayServerData(new RelayServerData(hostAllocation, OnlineState.k_DtlsConnType)); // This is with DTLS enabled for a secure connection
+            utp.SetRelayServerData(new RelayServerData(hostAllocation, k_DtlsConnType)); // This is with DTLS enabled for a secure connection
         }
     }
 }

Assets/Scripts/ConnectionManagement/ConnectionState/ClientConnectedState.cs

@@ -9,7 +9,7 @@ namespace Unity.BossRoom.ConnectionManagement
     /// Connection state corresponding to a connected client. When being disconnected, transitions to the
     /// ClientReconnecting state if no reason is given, or to the Offline state.
     /// </summary>
-    class ClientConnectedState : ConnectionState
+    class ClientConnectedState : OnlineState
     {
         [Inject]
         protected LobbyServiceFacade m_LobbyServiceFacade;
@@ -39,11 +39,5 @@ public override void OnClientDisconnect(ulong _)
                 m_ConnectionManager.ChangeState(m_ConnectionManager.m_Offline);
             }
         }
-
-        public override void OnUserRequestedShutdown()
-        {
-            m_ConnectStatusPublisher.Publish(ConnectStatus.UserRequestedDisconnect);
-            m_ConnectionManager.ChangeState(m_ConnectionManager.m_Offline);
-        }
     }
 }

Assets/Scripts/ConnectionManagement/ConnectionState/OnlineState.cs

@@ -5,8 +5,6 @@ namespace Unity.BossRoom.ConnectionManagement
     /// </summary>
     abstract class OnlineState : ConnectionState
     {
-        public const string k_DtlsConnType = "dtls";
-
         public override void OnUserRequestedShutdown()
         {
             // This behaviour will be the same for every online state

CHANGELOG.md

@@ -14,6 +14,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
 ### Fixed
 * EnemyPortals' VFX get disabled and re-enabled once the breakable crystals are broken (#784)
 * Elements inside the Tank's and Rogue's AnimatorTriggeredSpecialFX list have been revised to not loop AudioSource clips, ending the logging of multiple warnings to the console (#785)
+* ClientConnectedState now inherits from OnlineState instead of the base ConnectionState (#801)
 
 ## [2.0.4] - 2022-12-13
 ### Changed