fix: disabling NetworkBehaviours instead of destroying them [MTT-4481] (#718)

Author: fernando-cortez

Assets/Scripts/Gameplay/Input/ClientClickFeedback.cs

@@ -23,7 +23,7 @@ void Start()
         {
             if (NetworkManager.Singleton.LocalClientId != OwnerClientId)
             {
-                Destroy(this);
+                enabled = false;
                 return;
             }
 

Assets/Scripts/Utils/NetworkOverlay/NetworkStats.cs

@@ -72,7 +72,7 @@ public override void OnNetworkSpawn()
             bool isClientOnly = IsClient && !IsServer;
             if (!IsOwner && isClientOnly) // we don't want to track player ghost stats, only our own
             {
-                Destroy(this);
+                enabled = false;
                 return;
             }
 

CHANGELOG.md

@@ -24,6 +24,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
 ### Fixed
 * Subscribing to a message channel while unsubscribing is pending (#675)
 * Using ```Visible``` instead of ```Enabled``` to make sure RNSM continues updating when off (#702)
+* Some NetworkBehaviours are disabled instead of being destroyed (#718) - This preserves the index order for NetworkBehaviours between server and clients, resulting in no indexing issue for sending/receiving RPCs.
 
 ## [v1.3.0-pre] - 2022-06-23