Moved service error popup logic to dedicated class

Author: pdeschain

Assets/BossRoom/Scripts/Client/Game/State/ClientMainMenuState.cs

@@ -103,7 +103,6 @@ void OnAuthSignIn()
             void OnSignInFailed()
             {
                 m_SignInSpinner.SetActive(false);
-                PopupPanel.ShowPopupPanel("Authentication Error", "For some reason we can't authenticate the user anonymously - that typically means that project is not properly set up with Unity services.");
             }
         }
 

Assets/BossRoom/Scripts/Client/UI/UnityServicesUIHandler.cs

@@ -1,7 +1,9 @@
 using System;
+using System.Runtime.CompilerServices;
 using Unity.Multiplayer.Samples.BossRoom.Client;
 using Unity.Multiplayer.Samples.BossRoom.Shared.Infrastructure;
 using Unity.Multiplayer.Samples.BossRoom.Shared.Net.UnityServices.Infrastructure;
+using Unity.Services.Authentication;
 using Unity.Services.Lobbies;
 using UnityEngine;
 
@@ -25,26 +27,44 @@ void Initialize(ISubscriber<UnityServiceErrorMessage> serviceError)
         void ServiceErrorHandler(UnityServiceErrorMessage error)
         {
             var errorMessage = error.Message;
-            if (error.AffectedService == UnityServiceErrorMessage.Service.Lobby)
+            switch (error.AffectedService)
             {
-                if (error.OriginalException is LobbyServiceException lobbyServiceException)
+                case UnityServiceErrorMessage.Service.Lobby:
                 {
-                    if (lobbyServiceException.Reason == LobbyExceptionReason.LobbyConflict)
+                    if ((error.OriginalException is LobbyServiceException {Reason: LobbyExceptionReason.LobbyConflict}))
                     {
                         // LobbyConflict can have multiple causes. Let's add other solutions here if there's other situations that arise for this.
                         errorMessage += "\nSee logs for possible causes and solution.";
                         Debug.LogError($"Got service error {error.Message} with LobbyConflict. Possible conflict cause: Trying to play with two builds on the " +
                             $"same machine. Please use command line arg '{ClientMainMenuState.AuthProfileCommandLineArg} someName' to set a different auth profile.\n");
+
                     }
+                    PopupPanel.ShowPopupPanel("Service error", errorMessage);
+                    break;
                 }
-            }
+                case UnityServiceErrorMessage.Service.Authentication:
+                {
+                    if (error.OriginalException is AuthenticationException exception)
+                    {
+                        PopupPanel.ShowPopupPanel("Authentication Error",
+                            $"For some reason we can't authenticate the user anonymously - that typically means that project is not properly " +
+                            $"set up with Unity services or that there is no internet connection." +
+                            $" You can still use the Direct IP connection option. {exception.Message}");
 
-            PopupPanel.ShowPopupPanel("Service error", errorMessage);
+                    }
+                    break;
+                }
+                default:
+                {
+                    PopupPanel.ShowPopupPanel("Service error", errorMessage);
+                    break;
+                }
+            }
         }
 
         void OnDestroy()
         {
             m_Subscriptions.Dispose();
         }
     }
-}
+}

Assets/BossRoom/Scripts/Shared/Net/UnityServices/Auth/AuthenticationServiceFacade.cs

@@ -18,7 +18,7 @@ void InjectDependencies(IPublisher<UnityServiceErrorMessage> unityServiceErrorMe
             m_UnityServiceErrorMessagePublisher = unityServiceErrorMessagePublisher;
         }
 
-        void OnServiceException(AuthenticationException e)
+        void OnServiceException(RequestFailedException e)
         {
             Debug.LogWarning(e.Message);
 
@@ -30,7 +30,7 @@ void OnServiceException(AuthenticationException e)
         public void DoSignInAsync(Action onSigninComplete, Action onFailed, InitializationOptions initializationOptions)
         {
             var task = TrySignIn(initializationOptions);
-            UnityServiceCallsTaskWrapper.RunTask<AuthenticationException>(task, onSigninComplete, onFailed, OnServiceException);
+            UnityServiceCallsTaskWrapper.RunTask<RequestFailedException>(task, onSigninComplete, onFailed, OnServiceException);
         }
 
         async Task TrySignIn(InitializationOptions initializationOptions)