replacing null-conditional operators with Exception.InnerException property

Author: LPLafontaineB

Assets/Scripts/UnityServices/Auth/AuthenticationServiceFacade.cs

@@ -27,7 +27,7 @@ public InitializationOptions GenerateAuthenticationOptions(string profile)
             }
             catch (Exception e)
             {
-                var reason = $"{e.Message} ({e.InnerException?.Message})";
+                var reason = e.InnerException == null ? e.Message : $"{e.Message} ({e.InnerException.Message})";
                 m_UnityServiceErrorMessagePublisher.Publish(new UnityServiceErrorMessage("Authentication Error", reason, UnityServiceErrorMessage.Service.Authentication, e));
                 throw;
             }
@@ -46,7 +46,7 @@ public async Task InitializeAndSignInAsync(InitializationOptions initializationO
             }
             catch (Exception e)
             {
-                var reason = $"{e.Message} ({e.InnerException?.Message})";
+                var reason = e.InnerException == null ? e.Message : $"{e.Message} ({e.InnerException.Message})";
                 m_UnityServiceErrorMessagePublisher.Publish(new UnityServiceErrorMessage("Authentication Error", reason, UnityServiceErrorMessage.Service.Authentication, e));
                 throw;
             }
@@ -67,7 +67,7 @@ public async Task SwitchProfileAndReSignInAsync(string profile)
             }
             catch (Exception e)
             {
-                var reason = $"{e.Message} ({e.InnerException?.Message})";
+                var reason = e.InnerException == null ? e.Message : $"{e.Message} ({e.InnerException.Message})";
                 m_UnityServiceErrorMessagePublisher.Publish(new UnityServiceErrorMessage("Authentication Error", reason, UnityServiceErrorMessage.Service.Authentication, e));
                 throw;
             }
@@ -87,7 +87,7 @@ public async Task<bool> EnsurePlayerIsAuthorized()
             }
             catch (AuthenticationException e)
             {
-                var reason = $"{e.Message} ({e.InnerException?.Message})";
+                var reason = e.InnerException == null ? e.Message : $"{e.Message} ({e.InnerException.Message})";
                 m_UnityServiceErrorMessagePublisher.Publish(new UnityServiceErrorMessage("Authentication Error", reason, UnityServiceErrorMessage.Service.Authentication, e));
 
                 //not rethrowing for authentication exceptions - any failure to authenticate is considered "handled failure"
@@ -96,7 +96,7 @@ public async Task<bool> EnsurePlayerIsAuthorized()
             catch (Exception e)
             {
                 //all other exceptions should still bubble up as unhandled ones
-                var reason = $"{e.Message} ({e.InnerException?.Message})";
+                var reason = e.InnerException == null ? e.Message : $"{e.Message} ({e.InnerException.Message})";
                 m_UnityServiceErrorMessagePublisher.Publish(new UnityServiceErrorMessage("Authentication Error", reason, UnityServiceErrorMessage.Service.Authentication, e));
                 throw;
             }

Assets/Scripts/UnityServices/Lobbies/LobbyServiceFacade.cs

@@ -548,7 +548,7 @@ public void DoLobbyHeartbeat(float dt)
 
         void PublishError(LobbyServiceException e)
         {
-            var reason = $"{e.Message} ({e.InnerException?.Message})"; // Lobby error type, then HTTP error type.
+            var reason = e.InnerException == null ? e.Message : $"{e.Message} ({e.InnerException.Message})"; // Lobby error type, then HTTP error type.
             m_UnityServiceErrorMessagePub.Publish(new UnityServiceErrorMessage("Lobby Error", reason, UnityServiceErrorMessage.Service.Lobby, e));
         }
     }