Skip to content

fix: dead imps spawning on late join #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: dead imps spawning on late join #399

wants to merge 1 commit into from

Conversation

LPLafontaineB
Copy link
Contributor

Description (*)

This PR fixes the issue where clients connecting to an ongoing game would see imps that have already been killed and despawned by destroying the associating gameobjects on start if they are not spawned.

Related Pull Requests

Issue Number(s) (*)

Fixes issue(s): MTT-1558

Manual testing scenarios

  1. ...
  2. ...

Questions or comments

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

LukeStampfli
LukeStampfli approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@LukeStampfli LukeStampfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. This sounds like a bug to me though. Scene objects which already got despawned on the server should automatically get removed from the client.

SamuelBellomo
SamuelBellomo requested changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@SamuelBellomo SamuelBellomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be handled by SDK though. Is there a bug opened for this? Statically placed objects that have been despawned after joining should be despawned.

@SamuelBellomo SamuelBellomo added the 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. label Nov 4, 2021
@SamuelBellomo
Copy link
Contributor

This should be handled by SDK though. Is there a bug opened for this? Statically placed objects that have been despawned after joining should be despawned.

Answering my own question
Unity-Technologies/com.unity.netcode.gameobjects#1573

@LPLafontaineB LPLafontaineB mentioned this pull request Mar 29, 2022
Merged
4 tasks
@SamuelBellomo
Copy link
Contributor

Adding this for all PRs that have been opened since this new flow has been added. Please add your changelog here project changelog file and/or package changelog file

@SamuelBellomo
Copy link
Contributor

@fernando-cortez @LPLafontaineB should this PR be closed?

@LPLafontaineB
Copy link
Contributor Author

yes, this is not the right fix for this bug

@SamuelBellomo SamuelBellomo deleted the fix/dead-imps-spawning-on-late-join branch September 23, 2022 18:24
@SamuelBellomo SamuelBellomo restored the fix/dead-imps-spawning-on-late-join branch September 23, 2022 18:24
@LPLafontaineB LPLafontaineB deleted the fix/dead-imps-spawning-on-late-join branch October 3, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo requested changes

@pdeschain pdeschain pdeschain approved these changes

@LukeStampfli LukeStampfli LukeStampfli approved these changes

Assignees
No one assigned
Labels
4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LPLafontaineB @SamuelBellomo @pdeschain @LukeStampfli