Skip to content

feat: add buttons to cheat window #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 28, 2022
Merged

feat: add buttons to cheat window #446

merged 12 commits into from
Feb 28, 2022

Conversation

LPLafontaineB
Copy link
Contributor

Description (*)

This PR creates a prefab for the cheat window and its buttons, and adds deactivated buttons. This is to make the adding of new cheats easier.

Related Pull Requests

Issue Number(s) (*)

Fixes issue(s): None

Manual testing scenarios

Questions or comments

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@LPLafontaineB LPLafontaineB marked this pull request as ready for review January 21, 2022 14:22
@LPLafontaineB LPLafontaineB added 1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly labels Jan 21, 2022
SamuelBellomo
SamuelBellomo previously approved these changes Jan 31, 2022
View reviewed changes
pdeschain
pdeschain previously approved these changes Feb 4, 2022
View reviewed changes
@pdeschain pdeschain added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Feb 4, 2022
@LPLafontaineB LPLafontaineB dismissed stale reviews from pdeschain and SamuelBellomo via 08ac834 February 7, 2022 15:05
@LPLafontaineB LPLafontaineB enabled auto-merge (squash) February 9, 2022 14:15
@LPLafontaineB LPLafontaineB added the 1-Needs Review PR needs attention from the assignee and reviewers label Feb 15, 2022
SamuelBellomo
SamuelBellomo previously approved these changes Feb 17, 2022
View reviewed changes
@LPLafontaineB LPLafontaineB added 2-One More Review One review in, one to go 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. and removed 1-Needs Review PR needs attention from the assignee and reviewers 3-Good to Merge labels Feb 23, 2022
@LPLafontaineB
Copy link
Contributor Author

Put on hold until the GDC branch is ready

@SamuelBellomo SamuelBellomo removed the 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. label Feb 24, 2022
fernando-cortez
fernando-cortez reviewed Feb 25, 2022
View reviewed changes
@LPLafontaineB LPLafontaineB enabled auto-merge (squash) February 25, 2022 16:29
@LPLafontaineB LPLafontaineB merged commit a722eb8 into develop Feb 28, 2022
@LPLafontaineB LPLafontaineB deleted the feature/Add-buttons-to-cheat-window branch February 28, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@LukeStampfli LukeStampfli Awaiting requested review from LukeStampfli

@pdeschain pdeschain Awaiting requested review from pdeschain

Assignees

@pdeschain pdeschain

@SamuelBellomo SamuelBellomo

Labels
2-Easy This PR is trivial and can be reviewed quickly 2-One More Review One review in, one to go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LPLafontaineB @pdeschain @SamuelBellomo @fernando-cortez